fix: ignore non-JSON request bodies in obfuscator - #6
Open
JasonZhouPW wants to merge 1 commit into
Open
Conversation
|
Review-assist for
I only reviewed the public diff. No duplicate implementation PR, secret material, dependency install, live RPC call, local checkout mutation, payment action, or live-chain action from me here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
obfuscateResponsealready checks whether the body is JSON before parsing.obfuscateRequestparsed every string body directly, so a plain-text request body could raise aSyntaxErrorduring logging instead of being left unchanged.Validation
./node_modules/.bin/mocha --timeout 20000 --require should test/logging/request-obfuscator_test.jsfailed on the new non-JSON request-body regression./node_modules/.bin/eslint src/logging/request-obfuscator.js test/logging/request-obfuscator_test.jsgit diff --checkBounty context: submitted for the Bitgesell improvement / PR bounty program, related to BitgesellOfficial/bitgesell#81 and BitgesellOfficial/bitgesell#32. Payout details can be provided after maintainer approval.