fix: route mixed-case wallet commands correctly - #7
Open
tolga-tom-nook wants to merge 2 commits into
Open
Conversation
This was referenced May 27, 2026
Author
|
Pushed a follow-up test hardening commit (
Validation rerun locally:
|
|
Maintainers - this looks like another narrow, reviewer-friendly Bitgesell #81 slice. What appears concretely useful here:
Suggested acceptance checks:
If you want a stricter follow-up before merge, the most useful extra proof would be one explicit unchanged-case control (already-lowercase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client#command()multiwallet detection for mixed-case RPC method names.Requester.prepare().Bug / impact
this.methodsis keyed by lowercase RPC method names, andRequester.prepare()lowercases the outgoing method. However,Client#command('getBalance')checkedthis.methods['getBalance']before preparing the request. That missed multiwallet support and posted to/instead of/wallet/<wallet>, so mixed-case direct command calls could hit the wrong wallet context even though the RPC method sent to Bitgesell Core was valid lowercasegetbalance.RED / GREEN validation
RED on
origin/mainwith the new regression:GREEN after fix:
Bounty context
This is submitted for the Bitgesell improvement / PR bounty program:
Payout address if approved: EVM/USDT-compatible
0x4a76c7E64C08cF29B59eFC640b4ada97A270d428.Assisted by Hermes Agent.