UI refactoring, part 1.5: Settings #1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g1itch
force-pushed
the
ui-refactoring-settings
branch
2 times, most recently
from
3202f98 to
fb33b88
Compare
g1itch
force-pushed
the
ui-refactoring-settings
branch
2 times, most recently
from
cf44acb to
f24a1fd
Compare
g1itch
force-pushed
the
ui-refactoring-settings
branch
from
f24a1fd to
8fae07c
Compare
g1itch
force-pushed
the
ui-refactoring-settings
branch
3 times, most recently
from
5b0567b to
2ec7b79
Compare
PeterSurda
approved these changes
Sep 3, 2019
g1itch
force-pushed
the
ui-refactoring-settings
branch
2 times, most recently
from
4f782bc to
9e99420
Compare
|
@PeterSurda I added new method |
g1itch
force-pushed
the
ui-refactoring-settings
branch
from
9e99420 to
71631c3
Compare
if network settings have changed, drop network connections instead
g1itch
force-pushed
the
ui-refactoring-settings
branch
from
71631c3 to
24ae91a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
These changes are rebased from #1394 as simplest and most useful part. Them provide the ui-file based "Settings" dialog in order to simplify adding new settings or changing the way them handled with minimum new code (e.g. #1284 or #1489).
Translations are unaffected.