-
Notifications
You must be signed in to change notification settings - Fork 63
add CSS padding to speakers list #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
change Veldas title from Events Coordinator to Vice Executor in the english page and its respecive spanish translation
Couple of thoughts on this on @mbuguadouglas, but first thank you for putting in the work for this. The original issue was to do this for all Your change only applies to the speaker list. I did some digging. Here are some things that we will need to verify:
Bonus points.:Changes should be tested. I would love a pytest that uses playwright to evaluate the CSS values. - Learn more at - https://playwright.dev/docs/evaluating If you aren't able to do this, or need help we can file an issue and I'll be happy to work with you on this (Perhaps you can ping me in the BPD discord) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See Comment
Thanks for the prompt feedback @kjaymiller . And I think i get what youre saying in the first part, so Ill work on that. For the second part(on testing), i do not know much about that 😆 but id be happy to learn along the way. Using the resource assigned, ill be sure to contact you incase of any issues. |
I definitely get it. Let's get the change added and we can get the test implementation as another issue. |
_includes/conferences.html
Outdated
<div class="conference"> | ||
<h2> | ||
<a href="{{ conference.url }}">{{ conference.name }}</a> ({{ conference.dates }}) {% if conference.location != "_No response_" %}- {{ conference.location }}{% endif %} | ||
</h2> | ||
<p>Type: {{ conference.type }}</p> | ||
{% if conference.summary != "_No response_" %} | ||
{{ conference.summary | markdownify }} | ||
{% endif %} | ||
{% if conference.speaking != "_No response_" %} | ||
<h3>Speaking:</h3> | ||
<!-- add padding to the ul items--> | ||
<ul class="speaking-list"> | ||
<article> | ||
<h2> | ||
<a href="{{ conference.url }}">{{ conference.name }}</a> ({{ conference.dates }}) {% if conference.location != "_No response_" %}- {{ conference.location }}{% endif %} | ||
</h2> | ||
<p>Type: {{ conference.type }}</p> | ||
{% if conference.summary != "_No response_" %} | ||
{{ conference.summary | markdownify }} | ||
{% endif %} | ||
{% if conference.speaking != "_No response_" %} | ||
<h3>Speaking:</h3> | ||
<li> | ||
{{ conference.speaking | markdownify }} | ||
</ul> | ||
{% endif %} | ||
</li> | ||
{% endif %} | ||
</article> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try this
<div>
{% for conference in site.data.conferences %}
<article class="conference">
<h2>
<a href="{{ conference.url }}">{{ conference.name }}</a> ({{ conference.dates }}) {% if conference.location != "_No response_" %}- {{ conference.location }}{% endif %}
</h2>
<p>Type: {{ conference.type }}</p>
{% if conference.summary != "_No response_" %}
{{ conference.summary | markdownify }}
{% endif %}
{% if conference.speaking != "_No response_" %}
<h3>Speaking:</h3>
{{ conference.speaking | markdownify }}
{% endif %}
</article>
{% endfor %}
{% else %}
<b>No conferences</b>
{% endif %}
</div>
resolve issue #369, allowing for padding in speakers ul in the conference page