Skip to content

add CSS padding to speakers list #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 1, 2024
Merged

add CSS padding to speakers list #400

merged 6 commits into from
Sep 1, 2024

Conversation

mbvgua
Copy link
Contributor

@mbvgua mbvgua commented Aug 28, 2024

resolve issue #369, allowing for padding in speakers ul in the conference page

mbvgua added 3 commits August 28, 2024 12:18
change Veldas title from Events Coordinator to Vice Executor in the english page  and its respecive spanish translation
@kjaymiller
Copy link
Contributor

Couple of thoughts on this on @mbuguadouglas, but first thank you for putting in the work for this.

The original issue was to do this for all li objects on the site that are in article tags. This would create a consistency across the website.

Your change only applies to the speaker list.

I did some digging. Here are some things that we will need to verify:

  • What templates wrap content in the <article></article>. Should more or less do this.
    For You Can you verify that the template that the conferences page along with the other pages like about.html and open-source-program.html also are wrapped in <article> tags?

    • Can you replace your class with a more broad article > li tag that would apply this across the website?

Bonus points.:

Changes should be tested. I would love a pytest that uses playwright to evaluate the CSS values. - Learn more at - https://playwright.dev/docs/evaluating

If you aren't able to do this, or need help we can file an issue and I'll be happy to work with you on this (Perhaps you can ping me in the BPD discord)

Copy link
Contributor

@kjaymiller kjaymiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Comment

@mbvgua
Copy link
Contributor Author

mbvgua commented Aug 30, 2024

Thanks for the prompt feedback @kjaymiller . And I think i get what youre saying in the first part, so Ill work on that. For the second part(on testing), i do not know much about that 😆 but id be happy to learn along the way. Using the resource assigned, ill be sure to contact you incase of any issues.

@kjaymiller
Copy link
Contributor

I definitely get it. Let's get the change added and we can get the test implementation as another issue.

@mbvgua mbvgua requested a review from kjaymiller August 31, 2024 13:30
@mbvgua
Copy link
Contributor Author

mbvgua commented Aug 31, 2024

Handled the CSS stying bit thus resolving issue #369 .However the resulting issue brought up in #400 about playwright testing proved abit difficult to implement in code and I might need some more time to figure it out.

Comment on lines 3 to 18
<div class="conference">
<h2>
<a href="{{ conference.url }}">{{ conference.name }}</a> ({{ conference.dates }}) {% if conference.location != "_No response_" %}- {{ conference.location }}{% endif %}
</h2>
<p>Type: {{ conference.type }}</p>
{% if conference.summary != "_No response_" %}
{{ conference.summary | markdownify }}
{% endif %}
{% if conference.speaking != "_No response_" %}
<h3>Speaking:</h3>
<!-- add padding to the ul items-->
<ul class="speaking-list">
<article>
<h2>
<a href="{{ conference.url }}">{{ conference.name }}</a> ({{ conference.dates }}) {% if conference.location != "_No response_" %}- {{ conference.location }}{% endif %}
</h2>
<p>Type: {{ conference.type }}</p>
{% if conference.summary != "_No response_" %}
{{ conference.summary | markdownify }}
{% endif %}
{% if conference.speaking != "_No response_" %}
<h3>Speaking:</h3>
<li>
{{ conference.speaking | markdownify }}
</ul>
{% endif %}
</li>
{% endif %}
</article>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try this

<div>
{% for conference in site.data.conferences %}
  <article class="conference">
    <h2>
      <a href="{{ conference.url }}">{{ conference.name }}</a> ({{ conference.dates }}) {% if conference.location != "_No response_" %}- {{ conference.location }}{% endif %}
    </h2>
    <p>Type: {{ conference.type }}</p>
    {% if conference.summary != "_No response_" %}
      {{ conference.summary | markdownify }}
    {% endif %}
    {% if conference.speaking != "_No response_" %}
      <h3>Speaking:</h3>
          {{ conference.speaking | markdownify }}
    {% endif %}
  </article>
    {% endfor %}
{% else %}
<b>No conferences</b>
{% endif %}
</div>

@kjaymiller kjaymiller merged commit 309f883 into BlackPythonDevs:gh-pages Sep 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants