-
Notifications
You must be signed in to change notification settings - Fork 63
Add tests for Conferences script #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Conferences script #404
Conversation
Edit: After a good night's rest, I think I figured out why the CI was failing. The Hmm interestingly enough, I'm able to run the tests just fine locally. I'm not at all sure why the CI doesn't think it's getting a
|
We don't always need to use the GITHUB_TOKEN during tests, so let's make it an explicit call if we need it
This should allow playwright to finish setting up before running tests
@kjaymiller okay I promise I'm done making updates. This is forrealsies ready for review! |
tests/test.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the service started. I wonder if a fixture that starts the service and tears it down would be more reliable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
really minor change and a question. looks good though and about 99% there
Co-authored-by: Jay Miller <[email protected]>
@dragid10 - please run |
Fixes #384
TLDR Summary:
This PR does 3 things
What's new:
tests/test.py
:What's different:
_conferences/__main__.py
got refactored!Those tests though:
I get all tests passing when I run the tests locally!

Other Notes:
I caught why the URL was always being changed to None as mentioned in #384, in the original logic I forgot to set the
valid_url
variable to a real value when there is a valid url found 😅I was so focused on the unhappy path, that I neglected the happy one 😭