-
Notifications
You must be signed in to change notification settings - Fork 64
Add leadership model page #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add leadership model page #458
Conversation
@kjaymiller please help review this. Thanks |
@TimOsahenru I made some suggested changes |
I don't see the suggested changes. Please point me to it |
_config.yml
Outdated
@@ -30,6 +30,9 @@ navigation: | |||
- text: Community | |||
url: /community/ | |||
fa: fa fa-users fa-fw | |||
- text: Meet our leaders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- text: Meet our leaders |
meet-our-leaders.md
Outdated
--- | ||
layout: default | ||
lang: en | ||
title: Meet our leaders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: Meet our leaders | |
title: Leadership |
_config.yml
Outdated
@@ -30,6 +30,9 @@ navigation: | |||
- text: Community | |||
url: /community/ | |||
fa: fa fa-users fa-fw | |||
- text: Meet our leaders | |||
url: /meet-our-leaders/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url: /meet-our-leaders/ |
_config.yml
Outdated
@@ -30,6 +30,9 @@ navigation: | |||
- text: Community | |||
url: /community/ | |||
fa: fa fa-users fa-fw | |||
- text: Meet our leaders | |||
url: /meet-our-leaders/ | |||
fa: fa fa-user-tie fa-fw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fa: fa fa-user-tie fa-fw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please confirm the changes you want me to make in the _config.yml
file. Do you want the /meet-our-leaders/
completely removed or you want the name changed to leadership ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completely removed from the _config.yml as it's used for navigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. I'm curious as to how we plan to navigate to the leadership page if it isn't included in the navigation links.
meet-our-leaders.md
Outdated
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="photo of Oleksis" src="https://github.com/oleksis.png"> | ||
<p><strong>Oleksis Fraga</strong><br/> | ||
Technical Manager</p> | ||
</article> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<article class="leadership-photo-container"> | |
<img class="leadership-photo" alt="photo of Oleksis" src="https://github.com/oleksis.png"> | |
<p><strong>Oleksis Fraga</strong><br/> | |
Technical Manager</p> | |
</article> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removed as per #463
meet-our-leaders.md
Outdated
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png"> | ||
<p><strong>Afi Gbadago</strong><br/> | ||
Open Source Project Coordinator</p> | ||
</article> | ||
|
||
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png"> | ||
<p><strong>Nuel</strong><br/> | ||
Co-Africa Events Coordinator</p> | ||
</article> | ||
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png"> | ||
<p><strong>Steve Yonkeu</strong><br/> | ||
Co-African Events Sponsorship Coordinator</p> | ||
</article> | ||
|
||
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png"> | ||
<p><strong>Nadir "Q" Abdullahq</strong><br/> | ||
US Events Coordinator</p> | ||
</article> | ||
</div> | ||
|
||
<div class="grid" style="display:flex; flex-wrap: wrap; justify-content:center;" markdown="1"> | ||
|
||
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png"> | ||
<p><strong>Damilola Oladele</strong><br/> | ||
Documentation Team Coordinator</p> | ||
</article> | ||
|
||
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png"> | ||
<p><strong>Ron Maravanyika</strong><br/> | ||
Zimbabwe Events Coordinator</p> | ||
</article> | ||
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png"> | ||
<p><strong>Benedict Kofi</strong><br/> | ||
US NYC Leadership Coordinator</p> | ||
</article> | ||
|
||
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png"> | ||
<p><strong>Sandra</strong><br/> | ||
New Members Liaison</p> | ||
</article> | ||
|
||
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png"> | ||
<p><strong>TBD</strong><br/> | ||
Content Team Coordinator</p> | ||
</article> | ||
|
||
<article class="leadership-photo-container"> | ||
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png"> | ||
<p><strong>TBD</strong><br/> | ||
Code of Conduct Team Coordinator</p> | ||
</article> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a simplified list like our leadership council.
meet-our-leaders.md
Outdated
The BPD Meetup Leaders are those responsible for the execution of our local meetups in select areas. | ||
|
||
<!-- Meetup team --> | ||
<div class="grid" style="display:flex; flex-wrap: wrap; justify-content:center;" markdown="1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify to a Markdown List
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still one small change in there which is an update to the test
tests/test.py
Outdated
("events"), | ||
("community"), | ||
("meet-our-leaders"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
("meet-our-leaders"), | |
("leadership"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I make this change, I encounter a failing test as we don't have a leadership
route. Should I update the naming convention from meet-our-leaders.md
to leadership.md
instead? A 👍 for approval and I'll proceed.
Added a
meet-our-leaders/
URL to our nav links and used our logo as placeholder for those images not available, we can possibly create another issue to upload the respective pictures