Skip to content

Add leadership model page #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TimOsahenru
Copy link
Contributor

@TimOsahenru TimOsahenru commented Sep 20, 2024

Added a meet-our-leaders/ URL to our nav links and used our logo as placeholder for those images not available, we can possibly create another issue to upload the respective pictures

@TimOsahenru
Copy link
Contributor Author

@kjaymiller please help review this. Thanks

@kjaymiller
Copy link
Contributor

@TimOsahenru I made some suggested changes

@TimOsahenru
Copy link
Contributor Author

I don't see the suggested changes. Please point me to it

_config.yml Outdated
@@ -30,6 +30,9 @@ navigation:
- text: Community
url: /community/
fa: fa fa-users fa-fw
- text: Meet our leaders
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- text: Meet our leaders

---
layout: default
lang: en
title: Meet our leaders
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Meet our leaders
title: Leadership

_config.yml Outdated
@@ -30,6 +30,9 @@ navigation:
- text: Community
url: /community/
fa: fa fa-users fa-fw
- text: Meet our leaders
url: /meet-our-leaders/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: /meet-our-leaders/

_config.yml Outdated
@@ -30,6 +30,9 @@ navigation:
- text: Community
url: /community/
fa: fa fa-users fa-fw
- text: Meet our leaders
url: /meet-our-leaders/
fa: fa fa-user-tie fa-fw
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fa: fa fa-user-tie fa-fw

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please confirm the changes you want me to make in the _config.yml file. Do you want the /meet-our-leaders/ completely removed or you want the name changed to leadership ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completely removed from the _config.yml as it's used for navigation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. I'm curious as to how we plan to navigate to the leadership page if it isn't included in the navigation links.

Comment on lines 25 to 29
<article class="leadership-photo-container">
<img class="leadership-photo" alt="photo of Oleksis" src="https://github.com/oleksis.png">
<p><strong>Oleksis Fraga</strong><br/>
Technical Manager</p>
</article>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<article class="leadership-photo-container">
<img class="leadership-photo" alt="photo of Oleksis" src="https://github.com/oleksis.png">
<p><strong>Oleksis Fraga</strong><br/>
Technical Manager</p>
</article>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed as per #463

Comment on lines 45 to 105
<article class="leadership-photo-container">
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png">
<p><strong>Afi Gbadago</strong><br/>
Open Source Project Coordinator</p>
</article>

<article class="leadership-photo-container">
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png">
<p><strong>Nuel</strong><br/>
Co-Africa Events Coordinator</p>
</article>
<article class="leadership-photo-container">
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png">
<p><strong>Steve Yonkeu</strong><br/>
Co-African Events Sponsorship Coordinator</p>
</article>

<article class="leadership-photo-container">
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png">
<p><strong>Nadir "Q" Abdullahq</strong><br/>
US Events Coordinator</p>
</article>
</div>

<div class="grid" style="display:flex; flex-wrap: wrap; justify-content:center;" markdown="1">

<article class="leadership-photo-container">
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png">
<p><strong>Damilola Oladele</strong><br/>
Documentation Team Coordinator</p>
</article>

<article class="leadership-photo-container">
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png">
<p><strong>Ron Maravanyika</strong><br/>
Zimbabwe Events Coordinator</p>
</article>
<article class="leadership-photo-container">
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png">
<p><strong>Benedict Kofi</strong><br/>
US NYC Leadership Coordinator</p>
</article>

<article class="leadership-photo-container">
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png">
<p><strong>Sandra</strong><br/>
New Members Liaison</p>
</article>

<article class="leadership-photo-container">
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png">
<p><strong>TBD</strong><br/>
Content Team Coordinator</p>
</article>

<article class="leadership-photo-container">
<img class="leadership-photo" alt="bpd logo" src="/assets/images/bpd_stacked.png">
<p><strong>TBD</strong><br/>
Code of Conduct Team Coordinator</p>
</article>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a simplified list like our leadership council.

The BPD Meetup Leaders are those responsible for the execution of our local meetups in select areas.

<!-- Meetup team -->
<div class="grid" style="display:flex; flex-wrap: wrap; justify-content:center;" markdown="1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify to a Markdown List

Copy link
Contributor

@kjaymiller kjaymiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still one small change in there which is an update to the test

tests/test.py Outdated
("events"),
("community"),
("meet-our-leaders"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("meet-our-leaders"),
("leadership"),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I make this change, I encounter a failing test as we don't have a leadership route. Should I update the naming convention from meet-our-leaders.md to leadership.md instead? A 👍 for approval and I'll proceed.

@kjaymiller kjaymiller merged commit 5a9a163 into BlackPythonDevs:gh-pages Sep 27, 2024
2 checks passed
@TimOsahenru TimOsahenru deleted the add-leadership-model-page branch March 21, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants