Skip to content

Optimize Pico CSS color profiles and update MAINTAINERS.md #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

cmm25
Copy link
Contributor

@cmm25 cmm25 commented Sep 27, 2024

This PR addresses issue #277 by optimizing our use of Pico CSS, particularly focusing on the color profiles, and updating our documentation to reflect best practices.

Changes made:

  1. Removed unused color profiles from pico.colors.min.css to reduce file size

    • Reviewed and removed color profiles not actively used in our website
    • Aim to bring pico.colors.min.css to a size comparable to pico.min.css
  2. Updated MAINTAINERS.md with a new "Styling" section:

    • Added information about our use of Pico CSS
    • Included guidelines for maintaining and optimizing color profiles
    • Emphasized the importance of keeping pico.colors.min.css optimized
  3. Added notes in the "Styling" section about:

    • Regular review and optimization of pico.colors.min.css
    • Testing the website thoroughly after removing unused colors
    • Monitoring website performance after CSS optimizations
    • Re-evaluating color profiles when updating Pico CSS

These changes aim to:

  • Improve website performance by reducing CSS file size
  • Maintain the lightweight nature of Pico CSS
  • Provide clear guidelines for future contributors on CSS management

@kjaymiller
Copy link
Contributor

I can't review the changes on mobile (it's currently 3am).

I'm hoping we can create a simple artifact workflow that can be run to verify pages were not affected.

But I'll need a few days to implement. (I've done this in the past just need the time to execute on it)

@cmm25
Copy link
Contributor Author

cmm25 commented Sep 28, 2024

It's okay sir. But while I was doing this task I noticed also when inspection the main pico file also has alot that is unused which was reflected by shoe coverage tool in chrome. Then maybe I'll look how to create the artificat in the mean time.

@kjaymiller
Copy link
Contributor

It's okay sir. But while I was doing this task I noticed also when inspection the main pico file also has alot that is unused which was reflected by shoe coverage tool in chrome. Then maybe I'll look how to create the artificat in the mean time.

No worries I plan on tackling this using some code that I've developed in the past. I'll get the issue and pr added soon so we can merge this.

@kjaymiller kjaymiller added the design_change triggers the generate_screenshot workflow label Sep 29, 2024
@kjaymiller kjaymiller merged commit 6b9cb6f into BlackPythonDevs:gh-pages Sep 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design_change triggers the generate_screenshot workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants