Update Maintainers and Contributors file for overassigning issues #481
Conversation
There was a problem hiding this comment.
@TimOsahenru great work on this.
I made a note that needs to be address in the wording around working on multiple PRs at the same time. Please resolve that.
CONTRIBUTING.md
Outdated
| @@ -38,6 +38,8 @@ Follow these steps and note these guidelines to begin contributing: | |||
|
|
|||
| ## Working on an issue | |||
|
|
|||
| - As a first-time contributor, please do not request assignment to more than one issue at a time, except in rare scenarios where the issues are closely related. | |||
| - As a returning contributor, ensure that you do not have an open pull request before requesting assignment to a new issue. Your pull request from a previous issue must be reviewed and merged first. | |||
There was a problem hiding this comment.
I don't think that it's a problem that you work on multiple issues. I think the problem arises when second PR references changes in the first PR...
For instance:
- A USER edits a file
- The same USER wants to submit another PR but is working on the same branch as the file with changes.
- The MAINTAINER requests changes on the first PR which now need to be made on the second PR.
…ontributors-file-for-overassigning-issues
|
@kjaymiller I've implemented the requested changes, but I get a failing test when I run pytest. I've already pulled the latest changes from upstream. I think I understand the error message, but I'm struggling to find a solution, LOL. Please help. Thanks |
|
I pulled down changes and I'm not running into that issue. can you run |
|
@TimOsahenru - There may have been a push recently so try another pull of changes. I don't think any of that changed the _conferences section. |
…ontributors-file-for-overassigning-issues
I ran into a similar issue that I noticed doesn't happen when you do |
|
I've been worked on this bug, still no headway from my end. Previously, I've always ran our test case with |
|
@TimOsahenru - I'm not sure as I can't replicate the issue. |
Certainly it's from my end then |
|
is it okay to make a push regardless ? |
|
Finally got the tests to pass by slapping anything to the wall, hoping something sticks:
|
|
Wow that's a lot of things to get going but great troubleshooting. If you continue to have issues we need to look at our setup. There are a lot of things happening. Maybe we can simplify them somehow. |
agreed |
TimOsahenru
deleted the
update-maintainers-and-contributors-file-for-overassigning-issues
branch
No description provided.