Replace hero image with carousel slider #529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to add some tests to this. The fact that the page is loading gives me confidence but it would be good to see something. |
|
Hello @kjaymiller, I'm still having trouble getting my tests to pass, as mentioned in a previous pull request. Sometimes all my tests fail, so I was hesitant to include one. Do we have a maintainers' channel where I can share the error message? Maybe someone can help me troubleshoot. |
|
We don't but we can make one definitely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗:
Issue: #[Issue_Number]
#365
Type of Change
Description 📋
What: Provide an overview of the issue this PR addresses. Explain the context and background information.
Replaced the hero image with carousel slider that displays the post titles, feature images and a summary of the post
Why: Describe why the changes are being made. Highlight key updates, new features, or bug fixes.
How: Explain how these changes will affect the project or end-users.
Checklist ✅
pre-commit run --allAdditional Notes & Screenshots
Add any additional notes or comments that might be helpful for the reviewers.