-
Notifications
You must be signed in to change notification settings - Fork 63
556 auto generate post descriptions #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Initially found this really insightful ... wanted to try this and get my hands messy on it 😔. Did we happen to stream this? |
sadly no but I did write this blog post about it late last night - https://kjaymiller.com/blog/i-made-a-precommit-hook-it-wasn-t-that-bad.html I think the auto-generate posts thing was a temporary fix. I think long term the CLI in pre-commit is the better solution where we fail pre-commit run if there is no description. |
In the meantime. @TimOsahenru can you review the PR so we can get it pushed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I noticed that some articles still don’t have an author tag. We could consider adding a default, like 'BPD,' for articles without a specified author to keep things consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a default author for this to make things a bit consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this too... we could have "BPD" as a default author for those articles without authors
Good news is I was the author of these posts so I can update that in a followup issue. I think a new issue (not to delay this PR) is to have fields that have to be filled in order for pre-commit to pass... I think we can modify the existing Again I think that is a different issue. In fact the only reason this was added in this issue was that I wanted to ensure that our tests were passing. |
In the meantime @TimOsahenru if it's good add your review approval to get this wrapped up. |
Issue Link 🔗:
Issue: #[Issue_Number]
UPDATE
While trying to get tests to pass, I ran into an issue where the default post was not being applied. The most verbose fix is to auto apply it when it is missing.
I wrote about this in #564
To fix this I made a somewhat large change.
I updated the documentation in contributors.md
Type of Change
Description 📋
This PR uses the ollama_summarizer tool to check all the posts for descriptions, creating new descriptions if they currently do not exist.
It also adds the new descriptions to the meta descriptions as well as the blog lists instead of excerpts...
Excerpts were being cutoff in some posts and their HTML was showing. This tool instead can be used to quickly generate descritpions based on the contents and use AI to quickly update.
It's also easy to change the description if there is a report of a bad descriptions.
This will make our social media links more dynamic and engaging and also it will give folks a summary of the content they are about to explore.
Checklist ✅
pre-commit run --all
Additional Notes & Screenshots
Add any additional notes or comments that might be helpful for the reviewers.