Skip to content

Test/ide pi config generator#1444

Open
kilqwe wants to merge 2 commits into
BlazeUp-AI:mainfrom
kilqwe:test/ide-pi-config-generator
Open

Test/ide pi config generator#1444
kilqwe wants to merge 2 commits into
BlazeUp-AI:mainfrom
kilqwe:test/ide-pi-config-generator

Conversation

@kilqwe

@kilqwe kilqwe commented Jun 15, 2026

Copy link
Copy Markdown

Purpose / Description

The PiAdapter config in observal-server/services/ide/pi.py did not have dedicated unit tests. This PR adds the unit tests.

Fixes

Approach

Created test_ide_pi_config_generator.py with 15 unit tests that covers:

  • MCP config generation produces valid JSON with correct mcpServers schema.
  • Skill file generation returns correctly structured skill components.
  • Rules file (AGENTS.md) generation writes correct path and content.
  • Edge cases: empty/None inputs produce empty list (dict) with no crash.

How Has This Been Tested?

uv run pytest tests/test_ide_pi_config_generator.py -v

15 passed in 0.20s

uvx ruff check tests/test_ide_pi_config_generator.py

All checks passed!

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)

AI Assistance

Was generative AI tooling used to co-author this PR?

  • Yes(Please Specify the tool): Claude Sonnet 4.6 (Low).
  • Was the generated code manually reviewed and tested?

@CLAassistant

CLAassistant commented Jun 15, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added new contributor Pull request from a first-time contributor server Pull request touches server code tests Pull request adds or modifies tests web Pull request touches web frontend code labels Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new contributor Pull request from a first-time contributor server Pull request touches server code tests Pull request adds or modifies tests web Pull request touches web frontend code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants