-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stats order #695
base: main
Are you sure you want to change the base?
Fix stats order #695
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 160 160
Lines 10919 10919
Branches 1199 1199
=======================================
Hits 9664 9664
Misses 1255 1255 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to return the stats sorted by the most recent one.
I was thinking we could add a sort query parameter, similar to the one used in endpoints that return multiple elements.
We can use this sort schema. We can then update the stats page trpc request by adding sort: "asc"
query param
While we’re at it, we could abstract this functionality into its own middleware,withSort
.
Don't forget to add a changeset |
Checklist
Description
Stats bar charts are displayed backwards
Related Issue
Closes #687