-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add support for fetching blocks by slot #700
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: ee895a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of expanding the scope of getByBlockId
, why not create a new method?
I prefer this too |
Because I want to expose this procedure as a REST endpoint, having two endpoints that essentially perform the same function—returning a block based on an ID—feels redundant. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
+ Coverage 88.50% 88.59% +0.08%
==========================================
Files 160 162 +2
Lines 10919 11038 +119
Branches 1199 1202 +3
==========================================
+ Hits 9664 9779 +115
- Misses 1255 1259 +4 ☔ View full report in Codecov by Sentry. |
Checklist
Description
It adds a new procedure
getBySlot
which enables consumers to fetch blocks by their slot. It also exposes the procedure as a REST endpoint.Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):