fix(marketplace): guard realtime bid updates against stale and duplicate deliveries#300
Merged
MaryammAli merged 2 commits intoJul 17, 2026
Conversation
Contributor
|
you have conflict |
Contributor
Author
|
conflict resolved ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292
Summary
This PR fixes inconsistencies in the marketplace's realtime bid updates caused by duplicate, stale, and out-of-order websocket events. It also stabilizes realtime subscriptions and ensures marketplace views stay synchronized with the latest listing state.
Problem
The marketplace updated
bidCountby incrementing it for every websocket event, whilecurrentBidwas derived usingMath.max(). As a result:Changes
Testing
✅ All unit tests pass.
✅ Type checking passes.
✅ ESLint passes.
✅ Verified manually that: