Safety gates#59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the contract write safety gate across all backend write paths
Description
A network safety guard exists, but contract-affecting write paths are spread across refunds, payments, Soroban tooling, registry deployment, and developer endpoints. A missed guard could submit writes to the wrong network or while a kill switch is active.
Affected areas: app/backend/src/feature-flags/network-safety.guard.ts, app/backend/src/payments/, app/backend/src/refunds/, app/backend/src/soroban-tooling/, app/backend/src/contracts/, app/backend/src/developer/*, tests/docs.
Implementation scope:
Introduce a shared ContractWritePolicyService.
Require policy checks before every operation that can submit, deploy, upgrade, or mutate contract state.
Record audit entries for blocked and allowed mainnet/testnet writes.
Add route-level and service-level tests so guard bypasses are caught.
Acceptance criteria:
Every backend contract write path declares a policy key.
Kill switch blocks writes regardless of controller route.
Audit logs identify actor, network, contract ID, operation, and decision.
closes #9