Skip to content

Conversation

@Overtorment
Copy link
Member

@Overtorment Overtorment commented Oct 26, 2025

Note

Adds detectOurUtxos and expanded seedToCode outputs, makes tweak computation throw when no pubkeys found, pins dependencies, and updates CI install step.

  • Core:
    • Add SilentPayment.detectOurUtxos(tx, seed, tweakHex) to identify spendable taproot UTXOs.
    • Enhance seedToCode(...) to return address, Bscan, bscan, Bspend, bspend.
    • Change computeTweakForTx(...) to throw "No pubkeys found in transaction inputs" when none detected.
  • Tests:
    • Add cases for missing prevout script (error), seedToCode fields, and detectOurUtxos detection; keep existing vector checks.
  • Tooling/Deps:

Written by Cursor Bugbot for commit 682faa6. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@socket-security
Copy link

socket-security bot commented Oct 27, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​tsconfig/​recommended@​1.0.2 ⏵ 1.0.101001006782100
Updated@​types/​create-hash@​1.2.2 ⏵ 1.2.698 -110084 +1877100
Updatedvitest@​3.0.8 ⏵ 3.2.4981007999 +1100
Updatedecpair@​3.0.0-rc.0 ⏵ 3.0.0100 +110087 +280 +1100
Updatedbip32@​5.0.0-rc.0 ⏵ 5.0.0100 +110082 +187100
Updatedbitcoinjs-lib@​7.0.0-rc.0 ⏵ 7.0.099 +1100100 +188100
Updatedtypescript@​5.1.6 ⏵ 5.9.3100100909990

View full report


- name: Install node_modules
run: npm ci
run: npm i
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Reproducibility Issues After Removing package-lock.json

Deleting the package-lock.json file removes the guarantee of reproducible dependency installations. This also led to changing the CI workflow from npm ci to npm i, which may result in inconsistent builds across different environments.

Fix in Cursor Fix in Web

@Overtorment Overtorment merged commit 4eef277 into master Oct 27, 2025
4 checks passed
@Overtorment Overtorment deleted the bump-ver branch October 27, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants