Only check all WoT IDs once every 10 minutes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking once per minute hits a slow path in WoT.
ArneBab
force-pushed
the
reduce-frequency-of-updating-WoT-state
branch
from
2add1c6 to
d20695f
Compare
|
Fix: remove unnecessary import. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking once per minute hits a slow path in WoT.
Yes, we should fix WoT to make it cheap to check all IDs, or convert Sone to using the subscription-based WoT API, but since both don’t seem viable in the near term, this stronger rate-limiting should avoid overloading the node.