Pave path v4 #1

validcube · 2024-12-01T12:00:39Z

Description

Fixes #(issue)

Type of change

❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
❌ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)

Co-authored-by: Zongle Wang <[email protected]>

Co-authored-by: SuperDragonXD <[email protected]>

Copilot reviewed 68 out of 82 changed files in this pull request and generated no suggestions.

Files not reviewed (14)

gradle.properties: Language not supported
gradle/wrapper/gradle-wrapper.properties: Language not supported
lawnchair/res/layout-v28/task_desktop.xml: Language not supported
lawnchair/res/values-fr-rFR/strings.xml: Language not supported
lawnchair/res/values-hu-rHU/strings.xml: Language not supported
lawnchair/res/values-in-rID/strings.xml: Language not supported
flags/src/com/android/window/flags2/CustomFeatureFlags.java: Evaluated as low risk
.github/workflows/crowdin_download.yml: Evaluated as low risk
flags/src/com/android/window/flags2/Flags.java: Evaluated as low risk
flags/src/com/android/window/flags2/FeatureFlagsImpl.java: Evaluated as low risk
flags/src/com/android/window/flags2/FeatureFlags.java: Evaluated as low risk
SECURITY.md: Evaluated as low risk
flags/src/com/android/window/flags2/FakeFeatureFlagsImpl.java: Evaluated as low risk
flags/src/com/android/launcher3/FeatureFlagsImpl.java: Evaluated as low risk

Comments skipped due to low confidence (1)

README.md:20

[nitpick] The spaces around the em dashes were removed. For consistency, consider adding spaces around the em dashes: 'Taking Launcher3 — Android’s default home app — as a starting point'.

Lawnchair is a free, open-source home app for Android. Taking Launcher3—Android’s default home app—as a starting point, it ports Pixel Launcher features and introduces rich customization options.

Copilot reviewed 11 out of 13 changed files in this pull request and generated no suggestions.

Files not reviewed (2)

.github/workflows/crowdin.yml: Evaluated as low risk
CONTRIBUTING.md: Evaluated as low risk

Copilot reviewed 14 out of 14 changed files in this pull request and generated no suggestions.

Signed-off-by: Pun Butrach <[email protected]>

Copilot

Copilot reviewed 11 out of 14 changed files in this pull request and generated 1 suggestion.

Files not reviewed (3)

.github/workflows/crowdin.yml: Evaluated as low risk
CONTRIBUTING.md: Evaluated as low risk
compatLib/README.md: Evaluated as low risk

systemUI/README.md

Co-authored-by: Copilot <[email protected]> Signed-off-by: Pun Butrach <[email protected]>

Copilot

Copilot reviewed 11 out of 14 changed files in this pull request and generated 3 suggestions.

Files not reviewed (3)

compatLib/README.md: Evaluated as low risk
.github/workflows/crowdin_upload.yml: Evaluated as low risk
.github/workflows/crowdin.yml: Evaluated as low risk

Comments skipped due to low confidence (1)

SECURITY.md:37

The word 'endeavour' should be 'endeavor' to match American English spelling used elsewhere in the document.

We'll endeavour to respond quickly, and will keep you updated throughout the process.

Copilot · 2024-12-07T13:04:54Z

README.md

+
+### Development builds
+
+Interested in keeping yourself up-to-date with every Lawnchair development? Try our development build, these build offered the latest features and bug fixes at a cost of being slower and *might* introduce new bugs that have never been seen in stable. If you'd like to join in the fun, don't forget to make backup(s) and proceed with cautions.


The phrase 'these build offered' should be 'these builds offer'.

Suggested change

Interested in keeping yourself up-to-date with every Lawnchair development? Try our development build, these build offered the latest features and bug fixes at a cost of being slower and *might* introduce new bugs that have never been seen in stable. If you'd like to join in the fun, don't forget to make backup(s) and proceed with cautions.

Interested in keeping yourself up-to-date with every Lawnchair development? Try our development build, these builds offer the latest features and bug fixes at a cost of being slower and *might* introduce new bugs that have never been seen in stable. If you'd like to join in the fun, don't forget to make backup(s) and proceed with cautions.

Copilot · 2024-12-07T13:04:54Z

systemUI/README.md

The phrase 'all of the required SystemUI module like Common as helper for other SystemUI modules like Unfold for handling devices with hinges' is grammatically incorrect. It should be 'all of the required SystemUI modules, such as Common, which serves as a helper for other SystemUI modules like Unfold for handling devices with hinges.'

Suggested change

This directory contains all of the required SystemUI module like Common as helper for other SystemUI modules like Unfold for handling devices with hinges.

This directory contains all of the required SystemUI modules, such as Common, which serves as a helper for other SystemUI modules like Unfold for handling devices with hinges.

Copilot · 2024-12-07T13:04:54Z

CONTRIBUTING.md

@@ -33,7 +33,7 @@ For translation, visit [Lawnchair on Crowdin](https://lawnchair.crowdin.com) and
 ### 🧑‍💻 Code

 > [!NOTE]
-> For Lawnchair 9 to 13, see the branches with the `9-` to `13-` prefixes respectively.
+> For Lawnchair 9 to 14, see the branches with the `9-` to `14-` prefixes respectively.


The sentence should be 'For Lawnchair 9 to 14, see the branches with the 9- to 14- prefixes, respectively.'

Suggested change

> For Lawnchair 9 to 14, see the branches with the `9-` to `14-` prefixes respectively.

> For Lawnchair 9 to 14, see the branches with the `9-` to `14-` prefixes, respectively.

Copilot reviewed 11 out of 14 changed files in this pull request and generated no suggestions.

Files not reviewed (3)

.github/workflows/crowdin.yml: Evaluated as low risk
.github/workflows/crowdin_download.yml: Evaluated as low risk
.github/workflows/crowdin_upload.yml: Evaluated as low risk

Co-authored-by: SuperDragonXD <[email protected]>

Copilot

Copilot reviewed 11 out of 14 changed files in this pull request and generated 1 suggestion.

Files not reviewed (3)

compatLib/README.md: Evaluated as low risk
.github/workflows/crowdin_download.yml: Evaluated as low risk
.github/workflows/crowdin_upload.yml: Evaluated as low risk

CONTRIBUTING.md

Co-authored-by: Copilot <[email protected]> Signed-off-by: Pun Butrach <[email protected]>

Copilot

Copilot reviewed 11 out of 14 changed files in this pull request and generated 1 suggestion.

Files not reviewed (3)

compatLib/README.md: Evaluated as low risk
.github/workflows/crowdin.yml: Evaluated as low risk
.github/workflows/crowdin_upload.yml: Evaluated as low risk

SECURITY.md

Co-authored-by: Copilot <[email protected]> Signed-off-by: Pun Butrach <[email protected]>

Copilot

Copilot reviewed 11 out of 14 changed files in this pull request and generated 1 comment.

Files not reviewed (3)

compatLib/README.md: Evaluated as low risk
.github/workflows/crowdin.yml: Evaluated as low risk
.github/workflows/crowdin_download.yml: Evaluated as low risk

Comments suppressed due to low confidence (2)

CONTRIBUTING.md:31

The phrase 'as listed in this [this summary table]' should be 'as listed in this [summary table]'.

When using quotation marks, insert the symbols specific to the target language, as listed in this [this summary table](https://en.wikipedia.org/wiki/Quotation_mark#Summary_table);

SECURITY.md:31

[nitpick] The word 'endeavor' should be 'endeavour' to maintain consistency with British English spelling used elsewhere in the document.

We'll endeavor to respond quickly, and will keep you updated throughout the process.

Copilot · 2024-12-13T02:00:51Z

README.md

-   QuickSwitch support
-   Global Search support
-   Icons, fonts, and colors customization
+-   **Material You Theming:** Adapts to your wallpaper and system theme.


The phrase 'Material You Theming' should be 'Material You theming' for consistency with capitalization rules.

Suggested change

- **Material You Theming:** Adapts to your wallpaper and system theme.

- **Material You theming:** Adapts to your wallpaper and system theme.

validcube and others added 10 commits November 6, 2024 16:33

Update information to LC15

13ac370

LC15 Screenshot

ee23852

Apply suggestion from code-reviewer

368db3e

Co-authored-by: Zongle Wang <[email protected]>

Apply suggestion from code-reviewer

e5d960b

Co-authored-by: SuperDragonXD <[email protected]>

Installation badges and cert hash

289b902

Update Crowdin branch to 15

ea3c8fe

Merge Canary and Development

1716c8e

Update styling of cert hash

cb36eb5

Merge branch '15-dev' into pave-path-v4

d154cb5

Update compatlib

e8086eb

validcube requested a review from Copilot December 1, 2024 12:00

validcube force-pushed the 15-dev branch from 918a96e to f6295fc Compare December 1, 2024 12:01

Copilot AI reviewed Dec 1, 2024

View reviewed changes

validcube requested a review from Copilot December 1, 2024 12:01

Copilot AI reviewed Dec 1, 2024

View reviewed changes

validcube added 6 commits December 6, 2024 14:42

Merge branch '15-dev' into pave-path-v4

fa4447e

Update for Unified SystemUI

fbd8e4b

Improve dev build

873bbca

Consistency + Update local fonts

309901e

Consistency with ToC

6f6fe61

Fix awkward

b869cce

validcube requested a review from Copilot December 7, 2024 12:34

Copilot AI reviewed Dec 7, 2024

View reviewed changes

Link to Smartspacer

1e48e17

Signed-off-by: Pun Butrach <[email protected]>

validcube requested a review from Copilot December 7, 2024 12:48

Copilot AI reviewed Dec 7, 2024

View reviewed changes

systemUI/README.md Outdated Show resolved Hide resolved

validcube and others added 3 commits December 7, 2024 19:52

Update visual to LC15

6ec8819

Merge branch '15-dev' into pave-path-v4

135d549

Merge suggestion from GitHub Copilot Code Review

fed5ced

Co-authored-by: Copilot <[email protected]> Signed-off-by: Pun Butrach <[email protected]>

validcube requested a review from Copilot December 7, 2024 13:03

Copilot AI reviewed Dec 7, 2024

View reviewed changes

Fix typos and grammar in README files (GitHub Copilot Review)

2cf67ea

validcube requested a review from Copilot December 7, 2024 13:07

Copilot AI reviewed Dec 7, 2024

View reviewed changes

validcube and others added 7 commits December 7, 2024 20:10

English Accent Consistency

c912439

Windows Canary Phone Link compression is the worst

d40a1c4

Apply suggestions from code review

37238e7

Co-authored-by: SuperDragonXD <[email protected]>

Update release phase, security policy, and versioning

2f22812

Update systemUI/README.md

473a19b

Co-authored-by: SuperDragonXD <[email protected]>

Update README: Lawnchair 15 alpha to beta

4d0ea54

Use development instead of beta

a4c4043

validcube requested a review from Copilot December 12, 2024 13:30

Copilot AI reviewed Dec 12, 2024

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

validcube and others added 2 commits December 12, 2024 20:32

Update CONTRIBUTING.md

c81fd4c

Co-authored-by: Copilot <[email protected]> Signed-off-by: Pun Butrach <[email protected]>

Give subtle Google Developer Style guidelines

b6ce95c

validcube requested a review from Copilot December 12, 2024 14:29

Copilot AI reviewed Dec 12, 2024

View reviewed changes

SECURITY.md Outdated Show resolved Hide resolved

Update SECURITY.md

a75e62f

Co-authored-by: Copilot <[email protected]> Signed-off-by: Pun Butrach <[email protected]>

validcube requested a review from Copilot December 13, 2024 01:59

Copilot AI reviewed Dec 13, 2024

View reviewed changes

validcube closed this Feb 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pave path v4 #1

Pave path v4 #1

validcube commented Dec 1, 2024

Copilot AI left a comment

Copilot AI left a comment

Copilot AI Dec 7, 2024

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Copilot AI Dec 7, 2024

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Copilot AI Dec 7, 2024

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Copilot AI left a comment

Copilot AI left a comment

Copilot AI left a comment

Copilot AI Dec 13, 2024

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.


		### Development builds

		Interested in keeping yourself up-to-date with every Lawnchair development? Try our development build, these build offered the latest features and bug fixes at a cost of being slower and might introduce new bugs that have never been seen in stable. If you'd like to join in the fun, don't forget to make backup(s) and proceed with cautions.

	This directory contains all of the required SystemUI module like Common as helper for other SystemUI modules like Unfold for handling devices with hinges.
	This directory contains all of the required SystemUI modules, such as Common, which serves as a helper for other SystemUI modules like Unfold for handling devices with hinges.

	> For Lawnchair 9 to 14, see the branches with the `9-` to `14-` prefixes respectively.
	> For Lawnchair 9 to 14, see the branches with the `9-` to `14-` prefixes, respectively.

	- Material You Theming: Adapts to your wallpaper and system theme.
	- Material You theming: Adapts to your wallpaper and system theme.

Pave path v4 #1

Pave path v4 #1

Conversation

validcube commented Dec 1, 2024

Description

Type of change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI Dec 7, 2024

Choose a reason for hiding this comment

Copilot AI Dec 7, 2024

Choose a reason for hiding this comment

Copilot AI Dec 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI Dec 13, 2024

Choose a reason for hiding this comment