feat(#184): enhance accessibility and testing in frontend#219
Conversation
Xuccessor
left a comment
There was a problem hiding this comment.
Nice work on the accessibility pass, @0xVida! 🎉 The a11y code, tests, and test config (jest-axe + jsx-a11y + focus/contrast tweaks) all look solid, and CI is green across the board.
Holding back on the merge for one housekeeping reason: the +13k diff is largely generated lhr-*.json / lhr-*.html Lighthouse reports and heavy package-lock.json churn that shouldn't land in this PR. Could you:
• add lhr-* to .gitignore and remove those generated files from the commit
• prune unrelated package-lock.json updates
• keep just the a11y code, specs, and config changes
Once that's cleaned up I'll merge right away. 🙏
|
Hey 👋 Accessibility and test additions look great. There's a merge conflict against |
|
Thanks for this. The branch has real merge conflicts with main right now and won't merge cleanly — could you rebase against the latest main and push? Once it's clean I'll be glad to merge. |
Summary
This PR improves the frontend's accessibility by introducing automated accessibility testing, enforcing accessibility best practices through linting, and updating interactive components to provide a more inclusive experience for keyboard and screen reader users.
Changes
jest-axeand@axe-core/reactfor automated accessibility testing.eslint-plugin-jsx-a11yto enforce accessibility best practices during development.aria-label/aria-labelledby) to interactive elements where required.focus-visiblestyles.Acceptance Criteria
jest-axeis integrated into component tests and runs automated accessibility assertions.eslint-plugin-jsx-a11yis configured and all violations are fixed.aria-label,aria-labelledby).focus-visiblestyles.Verification
jest-axepasses on component tests.npm run lintreports no accessibility violations.Closes #184