Active development - #6
Conversation
Added detailed information about the Amalgam Discord bot, including its functionality, setup instructions, configuration, permissions, and requirements.
There was a problem hiding this comment.
There was a problem hiding this comment.
I have absolutely no clue what the requirements would be, but I will at this to the to-do list to get this done at a later time
There was a problem hiding this comment.
No, read the article
You list the required packages in the requirements.txt and then you do pip install -r requirements.txt to install them all
There was a problem hiding this comment.
Yes, but I don't know what the required packages are (I forgot, I have a horrible memory), so I'll look it up later
Rocked03
left a comment
Rocked03
left a comment
There was a problem hiding this comment.
have reviewed but have left the most detailed DB-related comments for another PR
| return | ||
|
|
||
| # Retrieve data from db for following executions | ||
| self.cursor.execute( |
There was a problem hiding this comment.
we should be using async everywhere, because synchronous operations will block the execution thread
ie whenever a synchronous SQL query is being executed, then any messages being sent through might be missed because the thread is being kept busy by the sync operation
whereas async lets things run in parallel, it's especially important for what could otherwise block the execution thread for seconds or more, but good practice regardless
There was a problem hiding this comment.
Sounds good, I will do this later since this a bit of a bigger change. I'll commit the other changes now
| reviews_db = "forward_reviews.db" | ||
| threads_db = "forward_threads.db" |
There was a problem hiding this comment.
why are these two separate files?
There was a problem hiding this comment.
Those very well could be merged, yes. Maybe a good thing to go over together when we go over all of the db stuff so we do it all right in one go :)
3 participants
Fixed all the changes proposed by Rocked, excluding db related stuff