Change SRData::from to take &[u8] rather than &Vec<u8>

Brendonovich · Aug 4, 2023 · 1506a08 · 1506a08
1 parent 03d5b7b
commit 1506a08
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/example/Cargo.lock b/example/Cargo.lock
diff --git a/src-rs/types/data.rs b/src-rs/types/data.rs
@@ -58,8 +58,8 @@ impl AsRef<[u8]> for SRData {
     }
 }
 
-impl From<&Vec<u8>> for SRData {
-    fn from(value: &Vec<u8>) -> Self {
+impl From<&[u8]> for SRData {
+    fn from(value: &[u8]) -> Self {
         unsafe { swift::data_from_bytes(value.as_ptr(), value.len() as Int) }
     }
 }

diff --git a/tests/test_bindings.rs b/tests/test_bindings.rs
@@ -134,7 +134,7 @@ swift!(fn echo_data(data: &SRData) -> SRData);
 fn test_data() {
     test_with_leaks!(|| {
         let str: &str = "hello";
-        let bytes = &str.as_bytes().to_vec();
+        let bytes = str.as_bytes();
         for _ in 0..10_000 {
             let data = unsafe { echo_data(&bytes.into()) };
             assert_eq!(data.as_slice(), bytes);