Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated notify types to match from IBrowserSyncOptions #2093

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bgturner
Copy link

I was using BrowserSync within a different package and noticed that the types for the notify indicate that it's only a boolean:

Screenshot 2024-11-12 at 10 02 56 AM

But it looks like the IBrowserSyncOptions interface has the notify key accepting a CSS styles object or array of CSS style rules.

I'm not as familiar with this project, so I just copied the type definition, but when I run a diff between the InitOptions and IBrowserSyncOptions, it looks like they're mostly the same except for InitOptions having:

    userPlugins: any[];
    session: number;

Screenshot 2024-11-12 at 11 18 58 AM

Should the types between these two things the same, or should we consider importing and extending IBrowserSyncOptions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant