Fix RFID 125 khz reading#2019
Merged
Merged
Conversation
It seems that for some reason, the previous code could not compute properly the checksum provided by the UART module properly. I did not find the reason but I guess some compiler optimisations or/and some conversion between long and int that introduced some errors. This code is a small different approach that does not use `strtol` method and convert nibbles to integer manually. The checksum is computed in one shot and compared with the one provided in the UI. I tested it on my cardputer and seems to work now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
It seems that for some reason, the previous code could not compute properly the checksum provided by the UART module properly. I did not find the reason but I guess some compiler optimisations or/and some conversion between long and int that introduced some errors.
Types of Changes
This code is a small different approach that does not use
strtolmethod and convert nibbles to integer manually.The checksum is computed in one shot and compared with the one provided in the UI.
Verification
Tested on my cardputer device
Testing
Linked Issues
Fix of issue #2014