More bullet-proof HTTP client - #86
Draft
SmylerMC wants to merge 25 commits into
Draft
Conversation
Also bumps Forge itself to 1.12.2-14.23.5.2864.
The game starts now.
This reverts commit 04b6eda8a3b501ef793c0a177fe08a7139574d8a.
This is supposedly the latest version compatible with Java 8.
(v6 does not support Java 8)
MixinPlatformAgentFMLLegacy, which is shipped by CubicChunks and loads mixins in pre 1.13 FML environments, has some logic for dev-time runs that assumes ForgeGradle 2 (see MixinPlatformAfentFMLLegacy#isIgnoredReparseable()). This logic fails on ForgeGradle 3+ because the cache directory for deobfuscated dependencies has been renamed from deobfedDeps to deobf_dependencies, and Mixin looks for deobfedDeps in the resolved mod file path. Because it resolves the path before the check, we can trick it with symlinks, which is the workaround.
- Gradle 7.6.6 - ForgeGradle 5.1.74
protected does not make sense for fields or methods in final classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request retry mechanism: