Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dependency handling for onUpdate hook #1702

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

nmerget
Copy link
Contributor

@nmerget nmerget commented Feb 26, 2025

Description

Please provide the following information:

Dependencies from onUpdate hook weren't used inside componentDidUpdate. By using @Watch we can generate a similar solution for onUpdate hook with dependencies.

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

@nmerget nmerget requested a review from samijaber as a code owner February 26, 2025 09:06
Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: c45b3c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Feb 26, 2025

View your CI Pipeline Execution ↗ for commit c45b3c7.

Command Status Duration Result
nx e2e @builder.io/e2e-app ✅ Succeeded 1m 5s View ↗
nx run-many --target test ✅ Succeeded 4m 46s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 3m 44s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 17s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-26 11:49:35 UTC

@samijaber samijaber merged commit 997f673 into BuilderIO:main Feb 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants