-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken angular block #1705
base: main
Are you sure you want to change the base?
Fix broken angular block #1705
Conversation
🦋 Changeset detectedLatest commit: 2f62566 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
View your CI Pipeline Execution ↗ for commit 2f62566.
☁️ Nx Cloud last updated this comment at |
|
||
// The generated Angular code should not have nested double quotes | ||
expect(template).not.toMatch(/="[^"]*"[^"]*"/); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general, we have the approach of using expect(template).toMatchInlineSnapshot()
so that we can notice any surprising changes across all tests when new PRs are made.
If you don't mind adding inline snapshots for relevant objects. See https://github.com/BuilderIO/mitosis/blob/main/packages/core/src/__tests__/builder.test.ts for examples of how we use it.
oyou just write toMatchInlineSnapshot()
, and once you run the tests it will populate it. See https://vitest.dev/guide/snapshot#inline-snapshots
Description
Updated parsing of innerHtml which was causing issues on code gen for angular.
yarn fmt:prettier
.yarn test:update
yarn g:changeset
and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.