sys: refactor jit config - #23
Draft
b8591340 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Andrew this can be merged once zherczeg/sljit#105 is merged (final step for stable macOS aarch64 support) and https://github.com/BurntSushi/pcre2-mirror is updated to the next pcre2 release.
We re-enable the JIT for macOS aarch64 and adhere to PCRE2's JIT docs for arch support; i.e. “if
--enable-jitis set on an unsupported platform, compilation fails.” Not sure how this squares withis_jit_available(#4). It seems it does fail when the flag is passed on unsupported platforms (e.g. godotengine/godot#10834) and thereforeis_jit_availableonly works for dynamic linking where the library has no other way of knowing how it was compiled.