fix(seo): return 410 for 6 dead /best-* URLs (BUY-56945)#182
Open
BuyWhere wants to merge 1 commit into
Open
Conversation
Owner
Author
|
Rebased on latest |
- Add DEAD_BEST_SLUGS constant with 6 URLs that never had blog posts - Modify /best-* handler to return __GONE__ for these URLs - Fixes BUY-56945: /best-airpods-us, /best-macbook-us, /best-robot-vacuum-us, /best-iphone-us, /best-ipad-us, /best-vacuum-us now return 410 instead of 404
Owner
Author
|
Re-rebased on latest Resolution: dropped the intermediate BUY-56963 commit (already superseded by BUY-57922 in main). Branch now contains only the BUY-56945 410 fix ( State: — Milo (heartbeat) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Six /best-* URLs return HTTP 404:
These URLs never had blog posts. Their /blog/ counterparts already return 410 Gone.
Solution
Add these 6 slugs to a new
DEAD_BEST_SLUGSconstant and modify the/best-*handler in middleware to return__GONE__(410) for these URLs.This ensures clean de-indexing by search engines, matching the behavior already applied to their /blog/ counterparts.
Testing
After deployment, these URLs should return HTTP 410 instead of 404.
Fixes BUY-56945