fix(BUY-61559): Add disclaimer to laptop-singapore editor summary table#209
Open
BuyWhere wants to merge 2 commits into
Open
fix(BUY-61559): Add disclaimer to laptop-singapore editor summary table#209BuyWhere wants to merge 2 commits into
BuyWhere wants to merge 2 commits into
Conversation
Add the existing HomeProductSearch component to the homepage hero section so users can search products directly from the main entry point instead of having to navigate to /search. Co-Authored-By: Paperclip <noreply@paperclip.ing>
Adds optional comparisonDisclaimer field to SeoLandingPageConfig. Renders disclaimer text below the comparison section heading. Sets disclaimer for laptop-singapore to clarify editorial picks may not match live catalog results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
comparisonDisclaimerfield to the editor summary table to clarify that editorial picks may not all appear in the live catalog.Problem
The "Popular laptop picks at a glance" table on
/laptop-singaporeshowed 5 hardcoded models with S$ prices, but 4 of those models (ASUS Zenbook 14 OLED, Lenovo Yoga 7i, Acer Swift Go 14, Dell XPS 14) did not appear in the live product cards above the table. Only the MacBook Air M3 matched.This was confusing for shoppers who could not find the advertised models in the live results.
Fix
comparisonDisclaimer?: stringtoSeoLandingPageConfigcomparisonDisclaimerforlaptop-singaporeto:Files changed
src/lib/seo-landing-pages.ts— config type + laptop-singapore entrysrc/components/seo/SeoLandingPage.tsx— renders disclaimer when presentTesting
tsc --noEmitpre-existing infra errors only)mainfor Railway auto-deploy