Skip to content

fix(BUY-63030): route MCP catalog reads through catalogDb; surface unavailable on zero-count category fallback #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BuyWhere wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(BUY-63030): route MCP catalog reads through catalogDb; surface unavailable on zero-count category fallback #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions mcp-railway/src/routes/mcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Router, Request, Response, NextFunction } from 'express';
import { db, redis, vectorDb } from '../config';
import { db, redis, vectorDb, catalogDb } from '../config';
import { embedQuery } from '../jobs/embedProducts';
import { requireApiKey, checkRateLimit } from '../middleware/apiKey';
import { queryLogMiddleware } from '../middleware/queryLog';
Expand All @@ -13,9 +13,9 @@ async function acquireMcpClient() {
let timer: NodeJS.Timeout | undefined;
try {
return await Promise.race([
db.connect(),
catalogDb.connect(),
new Promise<never>((_, reject) => {
timer = setTimeout(() => reject(new Error('mcp_db_pool_acquire_timeout')), MCP_DB_ACQUIRE_TIMEOUT_MS);
timer = setTimeout(() => reject(new Error('mcp_catalog_db_pool_acquire_timeout')), MCP_DB_ACQUIRE_TIMEOUT_MS);
}),
]);
} finally {
Expand Down Expand Up @@ -193,7 +193,7 @@ let _hasDiscountPct: boolean | undefined;

async function probeDiscountPctColumn(): Promise<boolean> {
try {
const probe = await db.query(
const probe = await catalogDb.query(
`SELECT is_generated FROM information_schema.columns WHERE table_name = 'products' AND column_name = 'discount_pct' LIMIT 1`
);
return probe.rows.length > 0 && probe.rows[0].is_generated === 'ALWAYS';
Expand Down Expand Up @@ -280,9 +280,9 @@ async function handleSearchProducts(args: Record<string, unknown>) {
// blocking the entire 12s statement_timeout. The DB itself is fast (70-130ms) so
// any 8-12s MCP latency is pool-acquisition contention, not query execution.
const searchClient = await Promise.race([
db.connect(),
catalogDb.connect(),
new Promise<never>((_, reject) =>
setTimeout(() => reject(new Error('db.connect timeout after 2000ms')), 2000)
setTimeout(() => reject(new Error('catalog_db.connect timeout after 2000ms')), 2000)
),
]).catch(() => {
throw { code: -32603, message: 'Database connection timeout' };
Expand Down Expand Up @@ -469,7 +469,7 @@ async function handleGetProduct(args: Record<string, unknown>) {

let result;
try {
result = await db.query(
result = await catalogDb.query(
`SELECT id, sku AS source, source AS domain, url, title,
price, currency, image_url, brand, category_path,
avg_rating AS rating, review_count, metadata, updated_at, region, country_code
Expand Down Expand Up @@ -503,7 +503,7 @@ async function handleCompareProducts(args: Record<string, unknown>) {
const placeholders = validIds.map((_, i) => `$${i + 1}`).join(',');
let result;
try {
result = await db.query(
result = await catalogDb.query(
`SELECT id, sku AS source, source AS domain, url, title,
price, currency, image_url, brand, category_path,
avg_rating AS rating, review_count, metadata, updated_at, region, country_code
Expand All @@ -525,7 +525,7 @@ async function getRegionalProductSample(
t0: number,
) {
try {
const result = await db.query(
const result = await catalogDb.query(
`SELECT id, sku AS source, source AS domain, url, title,
price, NULL::numeric AS original_price, currency, image_url,
metadata, updated_at, region, country_code, 0::numeric AS discount_pct
Expand Down Expand Up @@ -940,6 +940,11 @@ async function handleFindBestPrice(args: Record<string, unknown>) {
};
}

// BUY-63030: catalog reads (search_products, get_product, compare_products,
// get_deals, list_categories, find_best_price, probeDiscountPctColumn) now
// route through catalogDb so we serve the canonical ~127M catalog instead of
// the primary maglev DB. Ingestion/auth/health stays on primary db.

// BUY-31929: MCP tool to ingest products — delegates to the same logic as
// POST /v1/ingest/products but via JSON-RPC tool call.
async function handleIngestProducts(args: Record<string, unknown>) {
Expand Down Expand Up @@ -1252,7 +1257,7 @@ async function handleFindSimilar(args: Record<string, unknown>) {
// Step 3: fetch product details from main DB
const nearIds = nearResult.rows.map(r => r.product_id);
const ph = nearIds.map((_, i) => `$${i + 1}`).join(',');
const detailResult = await db.query(
const detailResult = await catalogDb.query(
`SELECT id, title, price, currency, source AS domain, url, image_url
FROM products WHERE id IN (${ph}) AND is_active = true`,
nearIds
Expand Down
Loading