fix(BUY-63740): Fix React hydration errors on SEO landing pages#237
Open
BuyWhere wants to merge 1 commit into
Open
fix(BUY-63740): Fix React hydration errors on SEO landing pages#237BuyWhere wants to merge 1 commit into
BuyWhere wants to merge 1 commit into
Conversation
- Replace nested <a> inside Next.js <Link> with <span role=button> + handlers - Use stable fallback label instead of new Date().toLocaleDateString() - Fixes Minified React error #418/#422 on production SEO pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes React hydration errors (minified errors #418/#422) on SEO landing pages in production.
Root Cause
Two distinct issues:
<a>inside Next.js<Link>violates React's rule against nested interactive elementsnew Date().toLocaleDateString()produced different values on server vs. clientChanges
ProductGridCard.tsx
<a href target=_blank>with<span role=button tabIndex=0>+ click/keyboard handlers usingwindow.open()SeoLandingPage.tsx
new Date().toLocaleDateString()fallback with stable string"Live prices updated regularly"updatedAttimestamp is availableVerification
VidMee renders against production URLs confirm:
Fixes BUY-63740