Open
Conversation
Collaborator
Author
|
launch jenkins(debug) |
|
The testsuite you launched for this PR has failed. You can inspect the results at this link. |
Collaborator
Author
|
Test results summary after Antarctica coastal glacier fix The change intentionally modifies output in Antarctic coastal regions to remove unrealistic high-albedo artefacts. All tests pass except for one:
The differences are expected and directly caused by this new correction ! enforce that the lu_class_fractions sum up to 1 (existing code above)
IF (lu_class_fraction(i,j,k,ilu_snow_ice) > 0.01_wp .AND. lat_geo(i,j,k) < -60._wp &
.AND. fr_land_lu(i,j,k) < 0.5_wp .AND. hh_topo(i,j,k) < 100._wp ) THEN
count_frland_ice = count_frland_ice + 1
lu_class_fraction(i,j,k,ilu_snow_ice) = 0.6_wp * fr_land_lu(i,j,k)
lu_class_fraction(i,j,k,ilu_bare_soil) = 0.4_wp * fr_land_lu(i,j,k)
alb_field_mom (i,j,k,1:12) = 0.15_wp
alnid_field_mom (i,j,k,1:12) = 0.15_wp
aluvd_field_mom (i,j,k,1:12) = 0.15_wp
ENDIF
**Other tests unaffected** (as expected):
- All COSMO-7/1, CCLM 12km, ICON-D2(+caching), Ecoclimap-SG, ECCI, Corine → green / bit-identical or within tolerance
**Recommendation**:
Since this is a deliberate improvement for physical realism (especially relevant for global/coarse grids), I suggest merge this PR afterwards
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modification from ICON (G. Zängl) transfered to EXTPAR checks if a grid cell at (i,j,k) has >1% snow/ice cover, is south of -60° latitude, has <50% land fraction, and is below 100m elevation.
If true, it:
Sets snow/ice fraction to 60% and bare soil to 40% of the land fraction.
Assigns a constant albedo of 0.15 to broadband, near-infrared, and UV/visible fields for all 12 months.