Replace pg_edgeidx_dsl mask by multiplying with 0.0#1053
Replace pg_edgeidx_dsl mask by multiplying with 0.0#1053
pg_edgeidx_dsl mask by multiplying with 0.0#1053Conversation
model/atmosphere/dycore/src/icon4py/model/atmosphere/dycore/dycore_states.py
Outdated
Show resolved
Hide resolved
|
cscs-ci run default |
|
cscs-ci run default |
havogt
changed the title
pg_edgeidx_dsl mask by multiplying with 0.0
|
cscs-ci run default |
|
Should we create a separate fix in icon-exclaim for this or just accumulate the changes with the other changes from #1052? |
muellch
left a comment
muellch
left a comment
There was a problem hiding this comment.
The only concern I have is that this might degrade performance.
The GPU might load all the data for the whole computation
z_gradh_exner + z_hydro_corr * pg_exdist
instead of one bool per thread.
A performance measurement would help here.
|
cscs-ci run default |
|
Good catch! |
let's accumulate, otherwise I spend the cycle fixing merge conflicts ;-) |
...con4py/model/atmosphere/dycore/stencils/compute_edge_diagnostics_for_dycore_and_update_vn.py
Outdated
Show resolved
Hide resolved
|
cscs-ci run default |
|
cscs-ci run distributed |
|
cscs-ci run default |
* main: Reject namelist parameters not supported (#1079) Update to gt4py v1.1.6 (#1081) Merge bdy halo stencils (#1066) Enable gauss3d experiment for distributed tests (#1013) Reenable MPS in CI (#1057) Don't compute RBF coefficients over whole domain to avoid non-positive definite matrices (#1077) muphys: Only write the surface level of the fluxes (#995) Update to gt4py v1.1.5 (#1072) Add missing asserts to dallclose calls (#1078) Print test durations in CI (#1058) Fix: Unconditionally exchange at end of corrector (#1074)
|
cscs-ci run distributed |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
cscs-ci run default |
3 participants
When naively translating a Fortran list to a full field, we constructed a mask instead of using the fact that we are actually initializing a weight with 0.0 in the masked-out cases.
Additionally: Remove program and a trivial test.