Conversation
havogt
commented
Feb 12, 2026
| @@ -126,8 +126,6 @@ def __init__( | |||
| smagorinski_scaling_factor: float = 0.015, | |||
Contributor
Author
There was a problem hiding this comment.
wondering if we should cherry-pick the changes in config from the configuration PR #936
Open
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run distributed |
jcanton
approved these changes
Feb 19, 2026
Contributor
jcanton
left a comment
There was a problem hiding this comment.
for a moment I thought you had removed thhgtd_zdiffu and thslp_zdiffu from the entire codebase :-)
LGTM
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run distributed |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thslp_zdiffuandthhgtd_zdiffufrom the Fortran bindings as they are not usedcompute_3d_smag_coeffas we don't support this modehdiff_w_efdt_ratioto the Fortran bindings (though for now we don't have any experiment that deviates from the default value)