Skip to content

Cleanup Diffusion config#1060

Open
havogt wants to merge 7 commits intomainfrom
cleanup_diffusion_config
Open

Cleanup Diffusion config#1060
havogt wants to merge 7 commits intomainfrom
cleanup_diffusion_config

Conversation

@havogt
Copy link
Contributor

@havogt havogt commented Feb 12, 2026

  • Remove thslp_zdiffu and thhgtd_zdiffu from the Fortran bindings as they are not used
  • Raise an error if compute_3d_smag_coeff as we don't support this mode
  • Add hdiff_w_efdt_ratio to the Fortran bindings (though for now we don't have any experiment that deviates from the default value)

@@ -126,8 +126,6 @@ def __init__(
smagorinski_scaling_factor: float = 0.015,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we should cherry-pick the changes in config from the configuration PR #936

@havogt havogt mentioned this pull request Feb 12, 2026
@havogt
Copy link
Contributor Author

havogt commented Feb 18, 2026

cscs-ci run default

@havogt
Copy link
Contributor Author

havogt commented Feb 18, 2026

cscs-ci run distributed

@havogt havogt requested review from jcanton and muellch February 18, 2026 16:24
Copy link
Contributor

@jcanton jcanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a moment I thought you had removed thhgtd_zdiffu and thslp_zdiffu from the entire codebase :-)
LGTM

@havogt
Copy link
Contributor Author

havogt commented Feb 24, 2026

cscs-ci run default

@havogt
Copy link
Contributor Author

havogt commented Feb 24, 2026

cscs-ci run distributed

@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants