Conversation
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
cscs-ci run distributed |
| @@ -311,19 +300,17 @@ def _read_vct_a_and_vct_b_from_file( | |||
| file_path: Path to the vertical grid file | |||
| num_levels: number of cell levels | |||
| allocator: GT4Py field allocator | |||
| Returns: one dimensional vct_a and vct_b arrays. | |||
| Returns: one dimensional vct_a arrays. | |||
There was a problem hiding this comment.
maybe explain here why vct_b is ignored (even though we keep the file format including vct_b for interoperability with fortran)
| Compute vct_a. | ||
|
|
||
| When the thickness of lowest level grid cells is larger than 0.01: | ||
| vct_a[k] = H (2/pi arccos((k/N)^s) )^d N = num_levels s = stretch_factor in vertical configuration |
There was a problem hiding this comment.
and add here a line, something like if needed vct_b can be computed as vct_b = np.exp(-vct_a / 5000.0) (so we don't have to look it up somewhere else)
| It is also used to modify the initial vertical wind speed above surface according to a prescribed vertical profile by linearly merging the surface vertical wind with the existing vertical wind. | ||
| See init_w and adjust_w in mo_nh_init_utils.f90. |
There was a problem hiding this comment.
| It is also used to modify the initial vertical wind speed above surface according to a prescribed vertical profile by linearly merging the surface vertical wind with the existing vertical wind. | |
| See init_w and adjust_w in mo_nh_init_utils.f90. |
these lines also refer to vct_b
There was a problem hiding this comment.
(if you think they're useful, move them to the other comment with the expression for vct_b)
|
Conclusion was: leave it icon4py, because potentially the vct_b might be custom in the grid file (or an alternative computation might be used), but we remove it from the Fortran bindings as we pass the derived quantities. |
|
replaced by #1082 |
2 participants
No description provided.