Rename ProcessProperties variables to consistent `process_props` naming by Copilot · Pull Request #1175 · C2SM/icon4py

Copilot · 2026-03-30T09:26:33Z

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

jenkins-apn · 2026-03-30T09:26:37Z

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

jenkins-apn · 2026-03-30T09:26:37Z

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

Rename all ProcessProperties variable names to `process_props`: - `processor_props` → `process_props` - `processor_procs` → `process_props` - `procs_props` → `process_props` - `run_properties` → `process_props` - `parallel_props` → `process_props` Rename functions for consistency with class name: - `get_processor_properties` → `get_process_properties` - `_get_processor_properties` → `_get_process_properties` - `get_processor_properties_for_run` → `get_process_properties_for_run` Fix error message typos: - "ProcessorProperties" → "ProcessProperties" Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/dde2809d-488a-4766-9cc1-cfb8aeedc7eb Co-authored-by: jcanton <5622559+jcanton@users.noreply.github.com>

jcanton · 2026-03-30T10:15:33Z

@copilot what about the bonus task? "Bonus: consider if ProcessProperties is the same as Communicator?"

Copilot · 2026-03-30T10:17:05Z

@copilot what about the bonus task? "Bonus: consider if ProcessProperties is the same as Communicator?"

ProcessProperties is not the same as a Communicator, though they're related.

ProcessProperties (Protocol) is a read-only data bag exposing comm, rank, comm_name, comm_size, and is_single_rank() — it describes who this process is within a communicator.

The actual communication happens through ExchangeRuntime (the Communicator-like abstraction), which provides start(), exchange(), my_rank(), get_size(). Its MPI implementation (GHexMultiNodeExchange) takes a ProcessProperties in __init__ and uses props.comm to create a GHEX context.

So the separation is:

ProcessProperties: identity/metadata about the local process in an MPI communicator (rank, size, comm handle)
ExchangeRuntime: the actual communication interface (halo exchanges, etc.)

ProcessProperties wraps the MPI communicator but doesn't perform communication itself — it's closer to a "communicator descriptor" than a "communicator". Merging them would conflate process identity with exchange logic, which the current design intentionally separates (e.g. create_exchange(props, decomp_info) is a factory that produces the right ExchangeRuntime based on ProcessProperties type).

msimberg · 2026-03-31T15:00:41Z

* **`ProcessProperties`**: identity/metadata about the local process in an MPI communicator (rank, size, comm handle)

Perhaps needs some in-person discussion, but an MPI communicator also contains the rank and size (and it obviously is the communication handle), so I'm not quite convinced by this argument. I think the main reason to keep some sort of wrapper around the MPI communicator class is if we want some level of abstraction 1. to allow e.g. NCCL communicators in the future (I'm not sure we need this anytime soon, GHEX handles this internally and NCCL communicators will most of the time need to be derived from MPI communicators) or 2. to allow adding properties functionality that is not directly available in the MPI commnunicator class (is_single_rank would be one example of this, I think).

…sor_properties Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/55210dc7-c18e-46ad-abf8-eac0d97384a7 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

msimberg · 2026-04-10T12:45:10Z

@copilot fix the conflicts with main.

…sproperties-variables # Conflicts: # model/driver/tests/driver/fixtures.py # model/standalone_driver/tests/standalone_driver/fixtures.py Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/6b4a3f9b-3dcc-4afa-9989-ab4e54a7c358 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

msimberg · 2026-04-10T12:52:16Z



-def get_processor_properties_for_run(
+def get_process_properties_for_run(


Should this be get_process_props or get_process_properties? I'm fine with the current version.

The current name get_process_properties matches the class name ProcessProperties, so it reads naturally. get_process_props would be an abbreviated form. Since you're fine with it, I'll leave it as-is.

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/a5390647-a39e-4115-aa3c-5fd119678341 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot · 2026-04-10T13:02:04Z

@copilot fix the conflicts with main.

The branch is already up to date with main — no conflicts. The previous merge in ba58d64 resolved the earlier conflicts.

msimberg · 2026-04-13T07:20:02Z

@copilot can you fix the formatting? The "ICON4Py Quality Assurance" check is currently failing.

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/1421024c-459e-4bc1-917e-81732d2f77d9 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot · 2026-04-13T07:24:12Z

@copilot can you fix the formatting? The "ICON4Py Quality Assurance" check is currently failing.

Fixed in 14db739. Ran ruff format on all changed Python files — 13 files had line-length formatting issues (mostly from the rename making lines exceed 100 chars).

msimberg · 2026-04-13T07:32:31Z

@copilot I think you made the formatting worse. Please fix the failing CI workflows.

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/13320c45-f902-4b06-963b-9902e1058623 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot · 2026-04-13T07:39:30Z

@copilot I think you made the formatting worse. Please fix the failing CI workflows.

Fixed in 68fdb96. The previous formatting commit used a newer ruff version (0.15.x) instead of the project-pinned 0.8.3 from uv.lock, which produced different formatting for assert statements. Re-ran ruff format with 0.8.3 on all 11 affected files.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

gridtools.github.io
- Triggering command: /home/REDACTED/.local/bin/uv uv sync --group dev (dns block)
releases.astral.sh
- Triggering command: /home/REDACTED/.local/bin/uv uv sync --group dev (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

msimberg · 2026-04-14T15:14:56Z

I'll try to fix the remaining mess that copilot has left locally. I think this is 95% there, but needs a bit of care to get to 100%.

msimberg · 2026-04-15T07:53:36Z

cscs-ci run default

msimberg · 2026-04-15T07:53:41Z

cscs-ci run distributed

msimberg · 2026-04-15T10:41:08Z

@copilot take care of conflicts.

…sproperties-variables # Conflicts: # tools/tests/tools/conftest.py Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot · 2026-04-15T10:43:49Z

@copilot take care of conflicts.

Resolved in 5fddc8e. The only conflict was in tools/tests/tools/conftest.py — main simplified the file by removing all the datatest imports and fixtures, so I accepted main's version.

msimberg · 2026-04-15T11:07:18Z

cscs-ci run default

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/427256a2-a3b5-4f34-8b1e-2958c72cf2cb Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

github-actions · 2026-04-15T13:07:06Z

Mandatory Tests

Please make sure you run these tests via comment before you merge!

cscs-ci run default
cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

Initial plan

6c6980b

Copilot AI assigned Copilot and jcanton Mar 30, 2026

Copilot AI linked an issue Mar 30, 2026 that may be closed by this pull request

Rename ProcessProperties variables to something consistent #1147

Open

Copilot started work on behalf of jcanton March 30, 2026 09:26 View session

Copilot AI changed the title ~~[WIP] Rename ProcessProperties variables for consistency~~ Rename ProcessProperties variables to consistent process_props naming Mar 30, 2026

Copilot finished work on behalf of jcanton March 30, 2026 09:42

Copilot AI requested a review from jcanton March 30, 2026 09:42

jcanton requested a review from msimberg March 30, 2026 10:12

jcanton marked this pull request as ready for review March 30, 2026 10:13

Copilot started work on behalf of jcanton March 30, 2026 10:15 View session

Copilot finished work on behalf of jcanton March 30, 2026 10:19

msimberg reviewed Apr 10, 2026

View reviewed changes

Comment thread model/driver/src/icon4py/model/driver/icon4py_driver.py Outdated

Copilot started work on behalf of msimberg April 10, 2026 12:40 View session

Rename props → process_props in initialize() and fix remaining proces…

00939f3

…sor_properties Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/55210dc7-c18e-46ad-abf8-eac0d97384a7 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

msimberg reviewed Apr 10, 2026

View reviewed changes

Comment thread model/testing/src/icon4py/model/testing/parallel_helpers.py Outdated

Copilot AI requested a review from msimberg April 10, 2026 12:46

Copilot finished work on behalf of msimberg April 10, 2026 12:46

Copilot started work on behalf of msimberg April 10, 2026 12:46 View session

msimberg reviewed Apr 10, 2026

View reviewed changes

Comment thread model/common/src/icon4py/model/common/decomposition/halo.py Outdated

Copilot AI and others added 2 commits April 10, 2026 12:48

Merge remote-tracking branch 'origin/main' into copilot/rename-proces…

ba58d64

…sproperties-variables # Conflicts: # model/driver/tests/driver/fixtures.py # model/standalone_driver/tests/standalone_driver/fixtures.py Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Merge main and rename remaining generic props → process_props

b190f0c

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/6b4a3f9b-3dcc-4afa-9989-ab4e54a7c358 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

msimberg reviewed Apr 10, 2026

View reviewed changes

Copilot started work on behalf of msimberg April 10, 2026 12:55 View session

Rename self._props → self._process_props in halo.py

76efc6e

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/a5390647-a39e-4115-aa3c-5fd119678341 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot finished work on behalf of msimberg April 10, 2026 13:00

Copilot started work on behalf of msimberg April 10, 2026 13:00 View session

Copilot finished work on behalf of msimberg April 10, 2026 13:03

Copilot started work on behalf of msimberg April 13, 2026 07:20 View session

Fix ruff formatting issues across all changed files

14db739

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/1421024c-459e-4bc1-917e-81732d2f77d9 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot finished work on behalf of msimberg April 13, 2026 07:26

Copilot started work on behalf of msimberg April 13, 2026 07:32 View session

Fix formatting with correct ruff 0.8.3 (project-pinned version)

68fdb96

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/13320c45-f902-4b06-963b-9902e1058623 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot finished work on behalf of msimberg April 13, 2026 07:40

Revert formatting changes in reference dycore.py file

e8d1a99

Copilot started work on behalf of msimberg April 15, 2026 10:41 View session

Merge remote-tracking branch 'origin/main' into copilot/rename-proces…

5fddc8e

…sproperties-variables # Conflicts: # tools/tests/tools/conftest.py Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot finished work on behalf of msimberg April 15, 2026 10:46

Copilot started work on behalf of msimberg April 15, 2026 12:11 View session

Fix processor_props regression in bindings/tests/conftest.py after merge

a5881c3

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/427256a2-a3b5-4f34-8b1e-2958c72cf2cb Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot finished work on behalf of msimberg April 15, 2026 12:14



		def get_processor_properties_for_run(
		def get_process_properties_for_run(

Conversation

Copilot AI commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jenkins-apn commented Mar 30, 2026

Uh oh!

jenkins-apn commented Mar 30, 2026

Uh oh!

jcanton commented Mar 30, 2026

Uh oh!

Copilot AI commented Mar 30, 2026

Uh oh!

msimberg commented Mar 31, 2026

Uh oh!

Uh oh!

Uh oh!

msimberg commented Apr 10, 2026

Uh oh!

Uh oh!

msimberg Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 10, 2026

Uh oh!

msimberg commented Apr 13, 2026

Uh oh!

Copilot AI commented Apr 13, 2026

Uh oh!

msimberg commented Apr 13, 2026

Uh oh!

Copilot AI commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

msimberg commented Apr 14, 2026

Uh oh!

msimberg commented Apr 15, 2026

Uh oh!

msimberg commented Apr 15, 2026

Uh oh!

msimberg commented Apr 15, 2026

Uh oh!

Copilot AI commented Apr 15, 2026

Uh oh!

msimberg commented Apr 15, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Mar 30, 2026 •

edited

Loading

Copilot AI commented Apr 13, 2026 •

edited

Loading