Replace dummy_exchange_with_bound_dim with noop derived from SingleNodeExchange#1177
Draft
Replace dummy_exchange_with_bound_dim with noop derived from SingleNodeExchange#1177
dummy_exchange_with_bound_dim with noop derived from SingleNodeExchange#1177Conversation
|
Hi there, this is jenkins continuous integration... |
1 similar comment
|
Hi there, this is jenkins continuous integration... |
…NodeExchange.exchange Remove the standalone dummy_exchange_with_bound_dim function and replace it with noop_exchange = functools.partial(single_node_default.exchange, dims.CellDim), which relies on the exchange objects directly as suggested in the issue. SingleNodeExchange.exchange is inherently a noop, making this a proper replacement. Updated all 9 test files that referenced the old function. Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/4b7a4e7b-4b0b-474f-b345-1d9cae17543d Co-authored-by: jcanton <5622559+jcanton@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Deduplicate dummy_exchange definition
Replace Mar 30, 2026
dummy_exchange_with_bound_dim with noop derived from SingleNodeExchange
Contributor
|
This change doesn't make sense... |
Contributor
|
But probably because I already did the deduplication in a previous PR and it didn't understand that there is nothing to do... Now it's more or less a rename but not for the better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dummy_exchange_with_bound_dimwas a standalone noop function duplicating behavior already provided bySingleNodeExchange.exchange. Replace it with afunctools.partialof the real exchange object.exchange_utils.py: Replace function definition with:SingleNodeExchange.exchangeis inherently a noop (returnsSingleNodeResultwhosefinish()is a pass), so the bound dimension is irrelevant.9 test files: Rename
exchange_utils.dummy_exchange_with_bound_dim→exchange_utils.noop_exchangeWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
gridtools.github.io/usr/bin/python3 /usr/bin/python3 /usr/lib/python3/dist-packages/pip/__pip-REDACTED__.py install --ignore-installed --no-user --prefix /tmp/pip-build-env-xe77e54j/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i REDACTED --find-links REDACTED -- setuptools>=61.0 wheel>=0.40.0 grep(dns block)/usr/bin/python3 /usr/bin/python3 /usr/lib/python3/dist-packages/pip/__pip-REDACTED__.py install --ignore-installed --no-user --prefix /tmp/pip-build-env-h6et9zmd/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i REDACTED --find-links REDACTED -- setuptools>=61.0 wheel>=0.40.0 grep(dns block)/usr/bin/pip pip install --find-links REDACTED -e model/common -e model/testing --quiet sphere/dycore/st-rs k/_temp/ghcca-no--destination-port grep -l ge 4py/tools/py2fgen/wrappers/grid_wrapper.py /home/REDACTED/work/_temp/ghcca-node/node/bin/grep ge sphere/dycore/st-a grep grep(dns block)If you need me to access, download, or install something from one of these locations, you can either:
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.