Draft
Conversation
- Replace `wget` library with `pooch` in data_handling.py - Use `pooch.retrieve()` with `pooch.Untar(extract_dir=".")` for downloading and extracting tar archives - Remove manual temp directory management and tarfile handling - Remove the private `_perform_download()` helper function - Update dependency in model/testing/pyproject.toml: wget>=3.2 -> pooch>=1.7.0 - Update root pyproject.toml: wget>=3.2 -> pooch>=1.7.0 - Update uv.lock to reflect dependency changes Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/97eae63c-abce-4bf1-90d6-1f7c34967217 Co-authored-by: jcanton <5622559+jcanton@users.noreply.github.com>
Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/97eae63c-abce-4bf1-90d6-1f7c34967217 Co-authored-by: jcanton <5622559+jcanton@users.noreply.github.com>
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1182. Still needs grid URLs updated and all of the data added to the object store. We can at the same time decide if the directory structure needs to be changed (though no particular need for that).
I've only added the r2b4 ape experiment data to the test bucket.