[ICON] add nvtx as as variant to ICON

[jonasjucker]

This variant enables to use nvtx ranges for profiling in a clean way.

[github-actions]

PR Preview Action v1.4.7
🚀 Deployed preview to https://C2SM.github.io/spack-c2sm/pr-preview/pr-992/
on branch gh-pages at 2024-08-22 08:00 UTC

[jonasjucker]

launch jenkins all

[dominichofer]

Interesting! Can you upstream it to https://github.com/spack/spack too?

[jenkins-apn]

balfrin

🟢 unit test

	Test
🟢	summary

🟢 integration test

	Test
🟢	clang-format-spack_info
🟢	clang-format-spack_spec
🟢	cosmo-eccodes-definitions-spack_info
🟢	cosmo-eccodes-definitions-spack_spec
🟢	cosmo-spack_info
🟢	cosmo-spack_spec
🟢	ecbuild-spack_info
🟢	ecbuild-spack_spec
🟢	eccodes-spack_info
🟢	eccodes-spack_spec
🟢	fdb-fortran-spack_info
🟢	fdb-fortran-spack_spec
🟢	fdb-spack_info
🟢	fdb-spack_spec
🟢	flexpart-cosmo-spack_info
🟢	flexpart-cosmo-spack_spec
🟢	flexpart-ifs-spack_info
🟢	flexpart-ifs-spack_spec
🟢	icon-ham-spack_info
🟢	icon-ham-spack_spec
🟢	icon-spack_info
🟢	icon-spack_spec
🟢	icon_extra-config-args=--disable-new_feature,--enable-old_config_arg-spack_spec
🟢	dace_icon.-O1-spack_spec
🟢	icon_serialization=create-spack_spec
🟢	icontools-spack_info
🟢	icontools-spack_spec
🟢	int2lm-spack_info
🟢	int2lm-spack_spec
🟢	int2lm_+parallel-spack_spec
🟢	int2lm_~parallel-spack_spec
🟢	libcdi-pio-spack_info
🟢	libcdi-pio-spack_spec
🟢	libfyaml-spack_info
🟢	libfyaml-spack_spec
🟢	libgrib1-spack_info
🟢	libgrib1-spack_spec
🟢	libtorch-spack_info
🟢	libtorch-spack_spec
🟢	makedepf90-spack_info
🟢	makedepf90-spack_spec
🟢	metkit-spack_info
🟢	metkit-spack_spec
🟢	oasis-spack_info
🟢	oasis-spack_spec
🟢	py-cytoolz-spack_info
🟢	py-cytoolz-spack_spec
🟢	py-devtools-spack_info
🟢	py-devtools-spack_spec
🟢	py-factory-boy-spack_info
🟢	py-factory-boy-spack_spec
🟢	py-frozendict-spack_info
🟢	py-frozendict-spack_spec
🟢	py-gridtools-cpp-spack_info
🟢	py-gridtools-cpp-spack_spec
🟢	py-gt4py-spack_info
🟢	py-gt4py-spack_spec
🟢	py-hatchling-spack_info
🟢	py-hatchling-spack_spec
🟢	py-icon4py-spack_info
🟢	py-icon4py-spack_spec
🟢	py-inflection-spack_info
🟢	py-inflection-spack_spec
🟢	py-lark-spack_info
🟢	py-lark-spack_spec
🟢	py-pytest-factoryboy-spack_info
🟢	py-pytest-factoryboy-spack_spec
🟢	py-tabulate-spack_info
🟢	py-tabulate-spack_spec
🟢	py-typing-extensions-spack_info
🟢	py-typing-extensions-spack_spec
🟢	python-spack_info
🟢	python-spack_spec
🟢	pytorch-fortran-proxy-spack_info
🟢	pytorch-fortran-proxy-spack_spec
🟢	pytorch-fortran-spack_info
🟢	pytorch-fortran-spack_spec
🟢	scales-ppm-spack_info
🟢	scales-ppm-spack_spec
🟢	xpmem-spack_info
🟢	xpmem-spack_spec
🟢	yaxt-spack_info
🟢	yaxt-spack_spec

🟢 system test

	Test
🟢	install_2024_1_nvhpc-icon_@2024.1-1_nvhpc
🟢	install_conditional_dependencies-icon_@2024.1-1_nvhpc_+coupling_serialization=create_+emvorado_+mpi_gpu=openacc+cuda_cuda_arch=80
🟢	install_cosmo_6_0-cosmo@6.0nvhpc
🟢	install_cosmo_eccodes_definitions_version-cosmo-eccodes-definitions_@2.19.0.7
🟢	install_cosmo_eccodes_definitions_version-cosmo-eccodes-definitions_@2.25.0.1
🟢	install_default-scales-ppm
🟢	install_eccodes_2_19_0-eccodes_@2.19.0
🟢	install_fdb_5_11_17_gcc-fdb_@5.11.17_gcc
🟢	install_fdb_5_11_17_nvhpc-fdb_@5.11.17_nvhpc
🟢	install_fdb_fortran-fdb-fortran
🟢	install_flexpart_cosmo-flexpart-cosmo_@V8C4.0
🟢	install_flexpart_ifs_version-flexpart-ifs_@10.4.4
🟢	install_flexpart_ifs_version-flexpart-ifs_@fdb
🟢	install_icon_24_1_gcc-icon_@2024.1-1_gcc
🟢	install_icontools-icontools_@2.5.2
🟢	install_int2lm_version_3_00_nvhpc_fixed_definitions-int2lm_@int2lm-3.00_nvhpc_^cosmo-eccodes-definitions@2.19.0.7nvhpc
🟢	install_libcdi_pio_default-libcdi-pio
🟢	install_libfyaml_default-libfyaml
🟢	install_libgrib1_22_01_2020_nvhpc-libgrib1_@22-01-2020nvhpc
🟢	install_libtorch_default-libtorch
🟢	install_makedepf90-makedepf90_@3.0.1
🟢	install_oasis_version_4_0_nvhpc-oasis_@4.0_nvhpc
🟢	install_py_gt4py_for_version-py-gt4py_@1.0.3.3
🟢	install_py_gt4py_for_version-py-gt4py_@1.0.3.7
🟢	install_py_gt4py_for_version-py-gt4py_@1.0.3.8
🟢	install_py_hatchling_default-py-hatchling
🟢	install_py_icon4py_version_0_0_10-py-icon4py_@_0.0.10_gcc_^py-gt4py@1.0.3.3
🟢	install_py_icon4py_version_0_0_11-py-icon4py_@_0.0.11_gcc_^py-gt4py@1.0.3.7
🟢	install_py_icon4py_version_0_0_12-py-icon4py_@_0.0.12_gcc_^py-gt4py@1.0.3.8
🟢	install_py_inflection_default-py-inflection
🟢	install_py_pyfactoryboy_default-py-pytest-factoryboy
🟢	install_py_tabulate_default-py-tabulate
🟢	install_py_typing_extensions_default-py-typing-extensions
🟢	install_pytorch_fortran_proxy_version_0_4-pytorch-fortran-proxy@0.4gcc_^python@3.10
🟢	install_pytorch_fortran_version_0_4-pytorch-fortran@0.4nvhpc_^pytorch-fortran-proxy@0.4gcc_^python@3.10_^gmakegcc_^cmakegcc
🟢	install_yaxt_default-yaxt
🟢	py_cytoolz_install_default-py-cytoolz
🟢	py_devtools_install_default-py-devtools
🟢	py_factory_boy_install_default-py-factory-boy
🟢	py_frozendict_install_default-py-frozendict
🟢	py_gridtools_cpp_install_default-py-gridtools-cpp

[jonasjucker]

Interesting! Can you upstream it to https://github.com/spack/spack too?

I was thinking about that. Looking at the package in spack it seems that only configure-option are included in the recipe.
Since there is no --enable-nvtx as configure-option I would not clutter the recipe.

[dominichofer]

But it's okay to clutter ours?

[jonasjucker]

I think so, since we will use it and also know how to use it :-)

Also this is alligned with our goal to build a hierarchy of icon-recipes we would go from
generic (spack recipe)
nwp (spack-c2sm recipe)
...

[dominichofer]

It's okay to clutter software that MeteoSwiss' operations rely on, even though we don't think it's good enough for the public icon community? I don't understand this logic.

[jonasjucker]

Ok then you don't

[stelliom]

@leclairm I think this is actually useful, what do you think? Note that this will also require to modify the nsys_wrapper.sh by adding nvtx to the --trace argument.