Skip to content

Adapt to new JSON format#1659

Merged
stelliom merged 2 commits intodev_v2.0from
adapt-to-new-json
Mar 3, 2026
Merged

Adapt to new JSON format#1659
stelliom merged 2 commits intodev_v2.0from
adapt-to-new-json

Conversation

@stelliom
Copy link
Contributor

No description provided.

@stelliom stelliom requested a review from mjaehn February 27, 2026 21:29
@stelliom stelliom changed the base branch from main to dev_v2.0 February 27, 2026 21:53
Copy link
Contributor

@mjaehn mjaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stelliom stelliom merged commit b03a04e into dev_v2.0 Mar 3, 2026
@stelliom stelliom deleted the adapt-to-new-json branch March 3, 2026 16:27
stelliom added a commit that referenced this pull request Mar 5, 2026
* Cleanup and refactoring (#1589)

* Cleanup rerun request workflow

* Use snake_case for variables in workflows

* Made issue templates names consistent

* Removed unnecessary copy_files function

* Refactored grid generation logic using nesting groups

Not tested - this will probably fail

* Added OutputManager

* Separated code in different files and classes

* Added intermediate output and on failure

* Added small comment

* Fixed small bug

* Always archive zip file

* Update function name

* Fixed access to domain_config

* Fixed small bug in move_files

* Fixed destination_filename bug

* Initialize program_failed

* Make EXTPAR config name settable

* Moved initialization of extpar_config_filename

* Change output logic

* Moved grid_sources to GridManager

* Revised todos

* Fixed typo in variable name

* Rework output directories structure

* Fixed missing f-string

* Transfer latlon to output

* Transfer config.json in output

* Skip latlon generation and visualization only when domain is not icontools

* Fixed typo

* Copy config.json instead of moving

* Make Zonda log available outside zip archive

* Fixed bug in visualization

* Improve logging

* Fix logging level increment

* Fixed logging bugs

* Fixed move_files logging indentation

* Updated src file structure

* Fix environment name

* Improved Jenkinsfiles and cleaned up scripts

* Revert changes to create_branch_from_issue.yml

* Readd naming change for issue.txt

* Readd checkout version change

* Update invalid report message

* Fix calls to zonda-rotgrid

* Fixed bug in archiveAndReport

* Added script region around calls to Groovy functions

* Fix loading of groovy files

* Fix loaded groovy variables

* Fix small bugs

* Temporarily use issue.txt instead of issue-id.txt

This is because the Github Action uses the YAML file on the main branch

* Fix location of process_request.py

* Use custom workspace name also for Request

* Actually fixed path to process_request.py

* Small fixes to invalid status message

* Add __init__.py to src/

* Add src/ to PYTHONPATH

* Escape dollar sign for PYTHONPATH

* Fix

* Continue if output files not found

* Fix argument names of report.py in post actions

* Fix Cleanup Jenkinsfile

* Add support for using input grids for all domains (#1613)

* Add support for using input grids for all domains

* Remove TODO comment

* Generate nests from input grid (#1614)

* First draft

* Pass input_grid_path to write_icon_gridgen_namelist

* Fixed padding

* Fixed all bugs

* Separate icontools dirs per nesting group

* Fixed small bug

* Pass icontools_dir to run_icon_gridgen

* Fixed namelist destination

* Allow for refinement of input grid even for nested domains

* Small fix

* Added empty line before and after subprocess output

* Rename grid files using global domain id when refinement starts from input grid

* Only move output of the current nesting group

* Rename also local HTML files with correct domain label

* Small changes to some logging strings

* Subtract 1 from grid_level due to initial_refinement (#1612)

* Visualize any EXTPAR field (#1615)

* First draft

* Support multiple EXTPAR variables

* Managers should not know about each other

* Support multi-dimensional EXTPAR variables

* Small fix

* Handle variables without certain attributes

* Added selected indices to plot file

* Correct pattern to delete branches

* Adapt to new JSON format (#1659)

* Change outfile to request_name

* Replace basegrid with globals

* Small fix in the logging level of visualization

* Pinned versions of packages in Conda env (#1590)

* Pinned versions of packages in Conda env

* Revert pinning packages in environment.yml

* Remove argparse package

It's already part of the standard library

* Add environment lock file

* Adapt Jenkins files to use lock file

* Changed issue.txt to issue-id.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants