-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉ログイン画面から、各画面の接続🎉 #86
Conversation
[共有事項] |
child: const Text('OK'), | ||
color: Theme.of(context).accentColor, | ||
onPressed: () async { | ||
// await context.read<InputParticipantInfoController>().handlePost(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これはいったんレビュースルーの方がいいやつ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#76 で対応する!
import 'package:morning_weakers/pages/new_profile/new_profile_controller.dart'; | ||
|
||
class OkButtonWidget extends StatelessWidget { | ||
@override | ||
Widget build(BuildContext context) { | ||
return FlatButton( | ||
child: const Text('ok'), | ||
child: const Text('OK'), | ||
color: Theme.of(context).primaryColor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こうやってprimaryColorとるのか!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良さそう!
メッセージ確認してもらったら、Approveする!
#94 でBugFix |
import 'package:morning_weakers/pages/input_participant_info/input_participant_info_page.dart'; | ||
|
||
class Menu extends StatelessWidget { | ||
final List<List<String>> menus = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final List<List<String>> menus = [ | |
final List<List<String>> _menus = [ |
privateにできそう
return Column( | ||
children: menus | ||
.map( | ||
(button) => ListTile( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(button) => ListTile( | |
(buttonTitle) => ListTile( |
の方が良さげ?
2395147
to
4b10b62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mergeするね! |
概要
対応するIssues番号
close #82