Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉ログイン画面から、各画面の接続🎉 #86

Merged
merged 16 commits into from
Jun 14, 2020

Conversation

tomu28
Copy link
Member

@tomu28 tomu28 commented Jun 13, 2020

概要

  • 各画面の接続
    • 【参加者・管理者】ログイン➡️プロフィール作成
    • 【参加者・管理者】プロフィール作成➡️ホーム画面・ドロワー
    • 【参加者】ホーム画面・ドロワー➡️参加者アンケート
    • 【参加者】参加者アンケート➡️グループ確認
    • 【管理者】ホーム画面・ドロワー➡️ハッカソン作成
    • 【管理者】ハッカソン作成➡️グループ分け
    • 【管理者】グループ分け➡️グループ確認

対応するIssues番号

close #82

@tomu28 tomu28 self-assigned this Jun 13, 2020
@tomu28 tomu28 requested review from zoothezoo, ryu1sazae and ho2ri2s and removed request for zoothezoo June 13, 2020 19:11
@tomu28
Copy link
Member Author

tomu28 commented Jun 13, 2020

[共有事項]
このcommit時では問題なく動作はしましたが、最新のmasterを取り込むとPOST時に動作が不安定になります。

child: const Text('OK'),
color: Theme.of(context).accentColor,
onPressed: () async {
// await context.read<InputParticipantInfoController>().handlePost();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これはいったんレビュースルーの方がいいやつ?

Copy link
Member Author

@tomu28 tomu28 Jun 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#76 で対応する!

import 'package:morning_weakers/pages/new_profile/new_profile_controller.dart';

class OkButtonWidget extends StatelessWidget {
@override
Widget build(BuildContext context) {
return FlatButton(
child: const Text('ok'),
child: const Text('OK'),
color: Theme.of(context).primaryColor,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こうやってprimaryColorとるのか!

Copy link
Contributor

@zoothezoo zoothezoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう!
メッセージ確認してもらったら、Approveする!

@tomu28
Copy link
Member Author

tomu28 commented Jun 14, 2020

#94 でBugFix

import 'package:morning_weakers/pages/input_participant_info/input_participant_info_page.dart';

class Menu extends StatelessWidget {
final List<List<String>> menus = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final List<List<String>> menus = [
final List<List<String>> _menus = [

privateにできそう

return Column(
children: menus
.map(
(button) => ListTile(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(button) => ListTile(
(buttonTitle) => ListTile(

の方が良さげ?

@tomu28 tomu28 force-pushed the feature/tomu28/connection_of_page branch from 2395147 to 4b10b62 Compare June 14, 2020 04:25
Copy link
Contributor

@ryu1sazae ryu1sazae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとう!!
kansya

Copy link
Contributor

@zoothezoo zoothezoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomu28
Copy link
Member Author

tomu28 commented Jun 14, 2020

mergeするね!

@tomu28 tomu28 merged commit c39a2ef into master Jun 14, 2020
@tomu28 tomu28 deleted the feature/tomu28/connection_of_page branch June 14, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

各画面の接続
3 participants