Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add timing module in lib_ccxr #1640

Merged
merged 11 commits into from
Sep 14, 2024

Conversation

IshanGrover2004
Copy link
Contributor

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Closes #1558

This PR adds types and functions to store and calculate timing related information during the decoding process. The functions are integrated into C.
After this PR merge, ccx_common_timing.c & ccx_common_timing.h file is completed ported to rust

@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented Aug 31, 2024

@prateekmedia Can you run cargo clippy -- -D warnings in parser.rs. See there are some warning like assert!(false).
So if you have any PR opened then fix in that or else let me know, I'll fix it in this PR

@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented Aug 31, 2024

@PunitLodha You can review the PR
Regression test result is looking good as well

@IshanGrover2004
Copy link
Contributor Author

IshanGrover2004 commented Aug 31, 2024

For the Windows build CI failing,
Here is the reason:
image

Edit: Fixed it

@PunitLodha
Copy link
Member

@IshanGrover2004 could you fix the conflict?

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 1a13bbb...:

Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 85/86
Teletext 21/21
WTV 13/13
XDS 34/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 1a13bbb...:

Report Name Tests Passed
Broken 12/13
CEA-708 9/14
DVB 4/7
DVD 3/3
DVR-MS 2/2
General 15/27
Hauppage 2/3
MP4 3/3
NoCC 10/10
Options 83/86
Teletext 21/21
WTV 0/13
XDS 22/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

@IshanGrover2004
Copy link
Contributor Author

@PunitLodha I think you can merge this, this PR is fine ig

@PunitLodha PunitLodha merged commit cbd8e27 into CCExtractor:master Sep 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants