Rspec linter #119
Open
Rspec linter #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tried to make sure I didn't commit anything here that was more opinionated than like, double quotes instead of single quotes
these ones are choices that the linter made, not all of which I am a huge fan of, so we may want to consider configuration or light refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR goes into the
rspecbranch because I didn't want to lint the old tests, although it wouldn't be hard to switch things out whichever way you decideI decided to throw in a linter (https://github.com/testdouble/standard). You can run it with
bundle exec standardrb. I split up the commits into two: 1 stuff that's straightforward, 2 things that need a little bit of eyeballIt has a few opinions I don't necessarily like, but I think it's probably configurable if we want to mess with that, or just live with its decisions. Or you can just close this PR and forget about it.
The cool news is that if you do like the linter, then I can set up a githook to run it before commits and also a github action to run it automatically when someone opens a PR.