-
Couldn't load subscription status.
- Fork 10
Joss paper #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Joss paper #816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It's a little over the 1000 words limit (I count ~1420 words) but it doesn't feel that long to read, so I would try to submit it and see if the reviewers request to shorten it
7a859f5 to
19f426f
Compare
d3a9975 to
3b1a464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I still think that it would help the reader to define the concepts a bit more formally before jumping into implementation details. This is however a choice, and given that choice, this is a very good presentation!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 90.11% 90.03% -0.09%
==========================================
Files 55 55
Lines 2925 2851 -74
Branches 986 969 -17
==========================================
- Hits 2636 2567 -69
+ Misses 91 90 -1
+ Partials 198 194 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jbigot can I get an other review for the last 2 commits please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes in the last 2 commits look great to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the JOSS docs:
The paper should be between 250-1000 words. Authors submitting papers significantly longer than 1000 words may be asked to reduce the length of their paper.
Beware, you are currently at ~1763 words
Co-authored-by: Julien Bigot <[email protected]>
Co-authored-by: Emily Bourne <[email protected]>
* Fix typos false positive * Correct key
Co-authored-by: Emily Bourne <[email protected]>
Co-authored-by: Emily Bourne <[email protected]>
|
@tpadioleau @article{Asahi2025, doi = {10.21105/joss.08391}, url = {https://doi.org/10.21105/joss.08391}, year = {2025}, publisher = {The Open Journal}, volume = {10}, number = {111}, pages = {8391}, author = {Asahi, Yuuichi and Padioleau, Thomas and Zehner, Paul and Bigot, Julien and Lebrun-Grandie, Damien}, title = {kokkos-fft: A shared-memory FFT for the Kokkos ecosystem}, journal = {Journal of Open Source Software} }@article{Bourne2025, doi = {10.21105/joss.08582}, url = {https://doi.org/10.21105/joss.08582}, year = {2025}, publisher = {The Open Journal}, volume = {10}, number = {113}, pages = {8582}, author = {Bourne, Emily and Grandgirard, Virginie and Asahi, Yuuichi and Bigot, Julien and Donnel, Peter and Hoffmann, Alexander and Kara, Abdelhadi and Krah, Philipp and Legouix, Baptiste and Malaboeuf, Etienne and Munschy, Yann and Obrejan, Kevin and Padioleau, Thomas and Protais, Matthieu and Vidal, Pauline}, title = {Gyselalib++: A Portable C++ Library for Semi-Lagrangian Kinetic and Gyrokinetic Simulations}, journal = {Journal of Open Source Software} } |
Yes of course, I would also like to add @blegouix as an author if he agrees ? |
|
@tpadioleau Yes with great pleasure, thank you for having though of me! |
Uh oh!
There was an error while loading. Please reload this page.