Skip to content

Conversation

@tpadioleau
Copy link
Member

The PR allows print_type_info, and print, to work for any kind of set of DiscreteElement. This is achieved by passing the extents of each dimension with a DiscreteVector that is common to all sets. A recursion is replaced by a fold expression.

I also took the opportunity to remove some unnecessary template functions making them inline for now.

@tpadioleau tpadioleau self-assigned this Oct 8, 2025
@tpadioleau tpadioleau force-pushed the 935-ddcprint_dim_name-only-handles-discretedomain branch from 9e2a71a to 27ed754 Compare October 8, 2025 17:22
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.62%. Comparing base (fc6a29e) to head (27ed754).

Files with missing lines Patch % Lines
include/ddc/print.hpp 90.90% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (90.90%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   92.63%   92.62%   -0.01%     
==========================================
  Files          55       55              
  Lines        2673     2670       -3     
  Branches      839      836       -3     
==========================================
- Hits         2476     2473       -3     
  Misses        112      112              
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant