Use StridedDiscreteDomains to pass the derivatives to the spline builders
#944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename some of the type aliases - use only one deriv dimension in the derivs_domain type aliases - enable the greville tests - lower the norm threshold for the triple derivative to 1e-10
- Fix code that was wrong in some assertions - Modify `get_whole_derivs_domain` to take the number of constraints for each dimension instead of the degree
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
+ Coverage 91.88% 92.16% +0.27%
==========================================
Files 57 57
Lines 2834 2922 +88
Branches 925 985 +60
==========================================
+ Hits 2604 2693 +89
+ Misses 136 135 -1
Partials 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the SplineBuilder interface to pass
StridedDiscreteDomains for the derivatives, which allows to pack some of the arguments and reduce the rate at which the number of arguments grows with the number of dimensions.This is based on #929