Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Frechet Distance #8284

Open
wants to merge 236 commits into
base: master
Choose a base branch
from
Open

New package: Frechet Distance #8284

wants to merge 236 commits into from

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Jun 12, 2024

Summary of Changes

Add a new package computing the approximate Fréchet distance between two polylines in dD under Euclidean metric, or decides if the distance is smaller than a given value.

Release Management

  • Affected package(s): Frechet_distance
  • Feature/Small Feature (if any): link
  • Link to compiled documentation: link
  • License and copyright ownership: MPI, GeometryFactory, cnrs(?)

TODO:

sloriot and others added 30 commits February 22, 2024 14:14
Still has to be completed.
Still not done, but at least a bit nicer.
This is just a starter to enable using the same types all over the
package.
@@ -63,6 +64,12 @@ struct Cartesian_filter_K : public Base_
typedef typename Store_kernel<EK_>::reference_type EK_rt;
EK_rt exact_kernel()const{return sek.kernel();}


// Added to be similar to CGAL::Filtered_kernel
typedef Kernel_d_interface<EK> Exact_kernel;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to @mglisse : think if there is a better place to put this, using Kernel_d_interface at this low level doesn't look right. Maybe in Kernel_d_interface, I can check if there is a type Exact_kernel, and in that case override it with a typedef using Kernel_d_interface (recursively)?

@@ -34,5 +38,50 @@ using Kernel = unspecified;
*/
using Point = unspecified_type;

/*! The number type of the filtered kernel. If
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ? something missing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better look at it once I ask for review. Sorry for these WIP commits.

@afabri
Copy link
Member

afabri commented Sep 20, 2024

/build:v1

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v1/Manual/index.html

@afabri
Copy link
Member

afabri commented Sep 20, 2024

If I get it correctly Epick_d has functors that are not in the concept Kernel_d. That is they are probably not in Cartesian_d.
For example Scaled_vector_d. So for the moment Frechet in dD will compile for Epick only.

@afabri
Copy link
Member

afabri commented Sep 20, 2024

/force-build:v1

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v1/Manual/index.html

@mglisse
Copy link
Member

mglisse commented Sep 20, 2024

If I get it correctly Epick_d has functors that are not in the concept Kernel_d. That is they are probably not in Cartesian_d.

Yes. The package Triangulation defines for instance a concept DelaunayTriangulationTraits that is not implied by the Kernel_d concept, it has Ep[ie]ck_d as models but not Cartesian_d.

@afabri
Copy link
Member

afabri commented Oct 22, 2024

/build:v1

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v1/Manual/index.html

@afabri
Copy link
Member

afabri commented Oct 22, 2024

/force-build:v1

Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v1/Manual/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHANGES.md not updated Feature Not yet approved The feature or pull-request has not yet been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epick_d and Has_filtered_predicates_tag
7 participants