-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: Frechet Distance #8284
base: master
Are you sure you want to change the base?
Conversation
Still has to be completed.
Still not done, but at least a bit nicer.
This is just a starter to enable using the same types all over the package.
Has to be debugged now...
@@ -63,6 +64,12 @@ struct Cartesian_filter_K : public Base_ | |||
typedef typename Store_kernel<EK_>::reference_type EK_rt; | |||
EK_rt exact_kernel()const{return sek.kernel();} | |||
|
|||
|
|||
// Added to be similar to CGAL::Filtered_kernel | |||
typedef Kernel_d_interface<EK> Exact_kernel; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to @mglisse : think if there is a better place to put this, using Kernel_d_interface at this low level doesn't look right. Maybe in Kernel_d_interface, I can check if there is a type Exact_kernel, and in that case override it with a typedef using Kernel_d_interface (recursively)?
…t a precomputed result
@@ -34,5 +38,50 @@ using Kernel = unspecified; | |||
*/ | |||
using Point = unspecified_type; | |||
|
|||
/*! The number type of the filtered kernel. If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
? something missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better look at it once I ask for review. Sorry for these WIP commits.
/build:v1 |
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v1/Manual/index.html |
If I get it correctly |
/force-build:v1 |
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v1/Manual/index.html |
Yes. The package Triangulation defines for instance a concept DelaunayTriangulationTraits that is not implied by the Kernel_d concept, it has Ep[ie]ck_d as models but not Cartesian_d. |
/build:v1 |
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v1/Manual/index.html |
/force-build:v1 |
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8284/v1/Manual/index.html |
Summary of Changes
Add a new package computing the approximate Fréchet distance between two polylines in dD under Euclidean metric, or decides if the distance is smaller than a given value.
Release Management
TODO: