IO of OpenMesh files - use doubles instead of floats
#8612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloriot
reviewed
Nov 15, 2024
sloriot
reviewed
Nov 15, 2024
Co-authored-by: Sebastien Loriot <[email protected]>
|
Successfully tested in CGAL-6.1-Ic-22 |
sloriot
added a commit
that referenced
this pull request
Dec 4, 2024
## Summary of Changes In OpenMesh, the outgoing halfedge of a boundary vertex must be the boundary halfedge. This PR fixes this orientation issue before writing the file, inside `write_OM()` This PR completes #8427 and #8612 ## Release Management * Affected package(s): BGL * License and copyright ownership: unchanged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The default OpenMesh point type is made of
floats. This PR changes the traits we use in CGAL to youdoubles and ensure that reading an off/writing an om/reading om gives the same result back.This PR completes #8427
Release Management