Spatial_search: Duplicate point handling

[soesau]

Summary of Changes

stop splitting nodes if the contained points are only duplicates

Release Management

• Affected package(s): dD Spatial Searching

[sloriot]

Successfully tested in CGAL-6.1-Ic-78

[sloriot]

Are you planning any more changes or shall we merge the branch?

[soesau]

Not yet.

[github-actions]

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

[soesau]

/build:v0

[github-actions]

There was an error while building the doc:

/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:187: SyntaxWarning: invalid escape sequence '\.'
  re_pkg_index=re.compile("\.\./([A-Z_a-z0-9]+)/index\.html")
/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:251: SyntaxWarning: invalid escape sequence '\('
  re_replace_in_file("operator<<\(\)", "operator&lt;&lt;()", f)
/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:322: SyntaxWarning: invalid escape sequence '\['
  re_replace_in_file('^.*\[ "Concepts",.*$', '', fn)
/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:332: SyntaxWarning: invalid escape sequence '\['
  re_replace_in_file('\[external\]', '', os.path.join('Manual','annotated.html'))

https://github.com/CGAL/cgal/actions/runs/13411027822

[sloriot]

Successfully tested in CGAL-6.1-Ic-93

[afabri]

There was an error while building the doc:

/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:187: SyntaxWarning: invalid escape sequence '\.'
  re_pkg_index=re.compile("\.\./([A-Z_a-z0-9]+)/index\.html")
/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:251: SyntaxWarning: invalid escape sequence '\('
  re_replace_in_file("operator<<\(\)", "operator&lt;&lt;()", f)
/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:322: SyntaxWarning: invalid escape sequence '\['
  re_replace_in_file('^.*\[ "Concepts",.*$', '', fn)
/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:332: SyntaxWarning: invalid escape sequence '\['
  re_replace_in_file('\[external\]', '', os.path.join('Manual','annotated.html'))

https://github.com/CGAL/cgal/actions/runs/13411027822

What goes wrong here??? @sloriot @albert-github

[albert-github]

In the commit:

Commit: b34d9d6808e661adc3db62e02dcc1f30f32b8486 [b34d9d6]
Parents: e7158f6e98
Author: Sébastien Loriot <[email protected]>
Date: Tuesday, March 5, 2024 1:13:25 PM
Committer: Sébastien Loriot
use raw string

there is a r added to the strings and this is correct and in the current master that I have (18f0405) this r is still present though in the shown log file it is not present anymore. Might be an artifact of the /build:v0 or something that is not correct in respect to the 5.6 branch.

Note I also see the same problem in the file generate_how_to_cite.py but here the line numbers in master have shifted a bit so looks like pointing in the same direction.

[sloriot]

/build:v0

[github-actions]

There was an error while building the doc:

/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:187: SyntaxWarning: invalid escape sequence '\.'
  re_pkg_index=re.compile("\.\./([A-Z_a-z0-9]+)/index\.html")
/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:251: SyntaxWarning: invalid escape sequence '\('
  re_replace_in_file("operator<<\(\)", "operator&lt;&lt;()", f)
/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:322: SyntaxWarning: invalid escape sequence '\['
  re_replace_in_file('^.*\[ "Concepts",.*$', '', fn)
/home/runner/work/cgal/cgal/Documentation/doc/scripts/html_output_post_processing.py:332: SyntaxWarning: invalid escape sequence '\['
  re_replace_in_file('\[external\]', '', os.path.join('Manual','annotated.html'))

https://github.com/CGAL/cgal/actions/runs/13491519283

[albert-github]

Very strange when looking at the 6.0 branch i.e. f7629fa it looks to me that the file html_output_post_processing.py is OK, maybe something in the merge process for the /build:v0?

[afabri]

I guess what counts at the end of the day: Is everything ok in the documentation testsuite.

[albert-github]

@afabri
I agree the documentation test suite is indeed the most important, but it is very strange and without knowing the cause it might hit again.

[github-actions]

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.