Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for foldovers so that they are not considered as coplanar #8734

Open
wants to merge 1 commit into
base: 5.6.x-branch
Choose a base branch
from
+9 −1
Open

Fix for foldovers so that they are not considered as coplanar #8734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/remesh_planar_patches.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@
#include <boost/iterator/function_output_iterator.hpp>
#include <boost/container/small_vector.hpp>

#ifdef CGAL_DEBUG_DECIMATION
#include <CGAL/IO/polygon_soup_io.h>
#endif

#include <algorithm>
#include <unordered_map>

Expand Down Expand Up @@ -243,7 +247,7 @@ bool is_edge_between_coplanar_faces(edge_descriptor e,
Point_ref_3 s = get(vpm, target(next(opposite(h, tm), tm), tm) );

if (coplanar_cos_threshold==-1)
return coplanar(p, q, r, s);
return coplanar(p, q, r, s) && coplanar_orientation(p, q, r, s)!=CGAL::POSITIVE;
else
{
typename Kernel::Compare_dihedral_angle_3 pred;
Expand Down Expand Up @@ -848,6 +852,10 @@ bool decimate_impl(const TriangleMeshIn& tm_in,

if (!is_polygon_soup_a_polygon_mesh(faces))
{
#ifdef CGAL_DEBUG_DECIMATION
CGAL::IO::write_polygon_soup("soup.off", corners, faces);
std::cout << "the output is not a valid polygon mesh!" << std::endl;
#endif
return false;
}

Expand Down